Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: chrome/browser/media/router/discovery/discovery_network_monitor_unittest.cc

Issue 2750453002: Add DiscoveryNetworkMonitor implementation (Closed)
Patch Set: Respond to mfoltz' comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/media/router/discovery/discovery_network_monitor.h"
6
7 #include "base/run_loop.h"
8 #include "content/public/browser/browser_thread.h"
9 #include "content/public/test/test_browser_thread_bundle.h"
10 #include "testing/gmock/include/gmock/gmock.h"
11 #include "testing/gtest/include/gtest/gtest.h"
12
13 namespace {
14
15 using content::BrowserThread;
16
17 using testing::_;
18 using testing::Invoke;
19
20 class MockDiscoveryObserver : public DiscoveryNetworkMonitor::Observer {
21 public:
22 MOCK_METHOD1(OnNetworksChanged, void(const DiscoveryNetworkMonitor&));
23 };
24
25 std::vector<DiscoveryNetworkInfo> FakeGetNetworkInfo(
26 const std::vector<DiscoveryNetworkInfo>& network_info_list) {
27 return network_info_list;
28 }
29
30 class DiscoveryNetworkMonitorTest : public testing::Test {
31 protected:
32 void SetUp() override {
33 // NetworkChangeNotifier provides singleton behavior while simultaneously
34 // allowing the creator to own the instance. This makes it possible to
35 // reset it for each test, however this isn't possible with LazyInstance<>,
36 // which DiscoveryNetworkMonitor uses. It's also not possible to just leave
37 // one NetworkChangeNotifier mock alive for all the tests because the thread
38 // bundle is being recreated in each fixture which causes their task runners
39 // to become different.
40 if (should_rebind_to_network_change_mock) {
41 discovery_network_monitor->RebindNetworkChangeObserverForTest();
42 } else {
43 should_rebind_to_network_change_mock = true;
44 }
45
46 // Clear the network info list and network ID before each test since the
47 // monitor is a singleton.
48 net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
49 net::NetworkChangeNotifier::CONNECTION_NONE);
50 base::RunLoop().RunUntilIdle();
51 }
52
53 static bool should_rebind_to_network_change_mock;
54
55 content::TestBrowserThreadBundle test_browser_thread_bundle;
56 MockDiscoveryObserver mock_observer;
57
58 std::vector<DiscoveryNetworkInfo> fake_ethernet_info{
59 {{std::string("enp0s2"), std::string("ethernet1")}}};
60 std::vector<DiscoveryNetworkInfo> fake_wifi_info{
61 {DiscoveryNetworkInfo{std::string("wlp3s0"), std::string("wifi1")},
62 DiscoveryNetworkInfo{std::string("wlp3s1"), std::string("wifi2")}}};
63
64 std::unique_ptr<net::NetworkChangeNotifier> network_change_notifier =
65 base::WrapUnique(net::NetworkChangeNotifier::CreateMock());
66
67 std::vector<DiscoveryNetworkInfo> fake_network_info;
68 DiscoveryNetworkMonitor* discovery_network_monitor =
69 DiscoveryNetworkMonitor::GetInstanceForTest(
70 base::Bind(&FakeGetNetworkInfo, base::ConstRef(fake_network_info)));
71 };
72
73 bool DiscoveryNetworkMonitorTest::should_rebind_to_network_change_mock = false;
74
75 } // namespace
76
77 TEST_F(DiscoveryNetworkMonitorTest, NetworkIdIsConsistent) {
78 fake_network_info = fake_ethernet_info;
79 std::string current_network_id;
80
81 auto capture_network_id =
82 [&current_network_id](const DiscoveryNetworkMonitor& monitor) {
83 DCHECK_CURRENTLY_ON(BrowserThread::IO);
84 current_network_id = monitor.GetNetworkId();
85 };
86 discovery_network_monitor->AddObserver(&mock_observer);
87 EXPECT_CALL(mock_observer, OnNetworksChanged(_))
88 .WillOnce(Invoke(capture_network_id));
89
90 net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
91 net::NetworkChangeNotifier::CONNECTION_ETHERNET);
92 base::RunLoop().RunUntilIdle();
93
94 std::string ethernet_network_id = current_network_id;
95
96 fake_network_info.clear();
97 EXPECT_CALL(mock_observer, OnNetworksChanged(_))
98 .WillOnce(Invoke(capture_network_id));
99
100 net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
101 net::NetworkChangeNotifier::CONNECTION_NONE);
102 base::RunLoop().RunUntilIdle();
103
104 fake_network_info = fake_wifi_info;
105 EXPECT_CALL(mock_observer, OnNetworksChanged(_))
106 .WillOnce(Invoke(capture_network_id));
107
108 net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
109 net::NetworkChangeNotifier::CONNECTION_WIFI);
110 base::RunLoop().RunUntilIdle();
111
112 std::string wifi_network_id = current_network_id;
113 fake_network_info = fake_ethernet_info;
114 EXPECT_CALL(mock_observer, OnNetworksChanged(_))
115 .WillOnce(Invoke(capture_network_id));
116
117 net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
118 net::NetworkChangeNotifier::CONNECTION_ETHERNET);
119 base::RunLoop().RunUntilIdle();
120
121 EXPECT_EQ(ethernet_network_id, current_network_id);
122 EXPECT_NE(ethernet_network_id, wifi_network_id);
123
124 discovery_network_monitor->RemoveObserver(&mock_observer);
125 }
126
127 TEST_F(DiscoveryNetworkMonitorTest, RemoveObserverStopsNotifications) {
128 fake_network_info = fake_ethernet_info;
129
130 discovery_network_monitor->AddObserver(&mock_observer);
131 EXPECT_CALL(mock_observer, OnNetworksChanged(_))
132 .WillOnce(Invoke([](const DiscoveryNetworkMonitor& monitor) {
133 DCHECK_CURRENTLY_ON(BrowserThread::IO);
134 }));
135
136 net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
137 net::NetworkChangeNotifier::CONNECTION_ETHERNET);
138 base::RunLoop().RunUntilIdle();
139
140 discovery_network_monitor->RemoveObserver(&mock_observer);
141 fake_network_info.clear();
142
143 net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
144 net::NetworkChangeNotifier::CONNECTION_NONE);
145 base::RunLoop().RunUntilIdle();
146 }
147
148 TEST_F(DiscoveryNetworkMonitorTest, RefreshIndependentOfChangeObserver) {
149 fake_network_info = fake_ethernet_info;
150
151 discovery_network_monitor->AddObserver(&mock_observer);
152 auto force_refresh_callback = []() {
153 DiscoveryNetworkMonitor* discovery_network_monitor =
154 DiscoveryNetworkMonitor::GetInstance();
155 EXPECT_NE(std::string("disconnected"),
156 discovery_network_monitor->GetNetworkId());
157 EXPECT_NE(std::string("unknown"),
158 discovery_network_monitor->GetNetworkId());
159 };
160
161 EXPECT_EQ(std::string("disconnected"),
162 discovery_network_monitor->GetNetworkId());
163 discovery_network_monitor->Refresh(base::Bind(force_refresh_callback));
164 base::RunLoop().RunUntilIdle();
165 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698