Add DiscoveryNetworkMonitor implementation

chrome/browser/media/router/discovery/discovery_network_info.h

+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DISCOVERY_NETWORK_INFO_H_
+#define CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DISCOVERY_NETWORK_INFO_H_

[mark a. foltz, 2017/05/26 21:38:54]

The main purpose of this file seems to be to support the API in
discovery_network_list.h, so it would be possible to fold this file into that
one.

It depends on whether there are other files that just need the struct and not
GetDiscoveryNetworkList, in which case, it would be better to keep them
separate.

[btolsch, 2017/05/26 23:38:10]

Well discovery_network_monitor.h needs this struct, but only
discovery_network_monitor.cc needs GetDiscoveryNetworkInfoList.  I'll leave it
as is for now but I'm not opposed to merging it with discovery_network_list.h

+
+#include <string>
+
+// Represents a single network interface that can be used for local discovery.
+struct DiscoveryNetworkInfo {
+ public:
+  DiscoveryNetworkInfo();
+  DiscoveryNetworkInfo(std::string name, std::string network_id);

[imcheng, 2017/05/26 23:49:00]

const std::string& for both parameters.

[btolsch, 2017/05/30 09:54:30]

Done.

+  ~DiscoveryNetworkInfo() = default;

[mark a. foltz, 2017/05/26 21:38:54]

If you're declaring the default ctor in the .cc you should declare the default
dtor there as well.

[btolsch, 2017/05/26 23:38:10]

Done.

+
+  DiscoveryNetworkInfo(const DiscoveryNetworkInfo&);
+  DiscoveryNetworkInfo& operator=(const DiscoveryNetworkInfo&);
+
+  bool operator==(const DiscoveryNetworkInfo&) const;
+  bool operator!=(const DiscoveryNetworkInfo&) const;
+
+  // The name of the network interface.  e.g. eth0, wlan0
+  std::string name;
+  // Some form of identifier for the network to which this interface is
+  // connected.  For WiFi, we assume the associated SSID identifies the
+  // connected network.  For Ethernet, we assume that the network remains the
+  // same for the interface (until disconnected), so we use the interface's MAC
+  // address to identify the network.
+  std::string network_id;
+};
+
+#endif  // CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DISCOVERY_NETWORK_INFO_H_