Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: Source/web/DateTimeChooserImpl.h

Issue 275043002: Oilpan: Prepare moving DateTimeChooser to Oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/DateTimeChooserImpl.h
diff --git a/Source/web/DateTimeChooserImpl.h b/Source/web/DateTimeChooserImpl.h
index f43b3d41f6e08c716c480c38813c06ebdf459cae..c66af8588c9aa3c5eaae9578d794efc65a516114 100644
--- a/Source/web/DateTimeChooserImpl.h
+++ b/Source/web/DateTimeChooserImpl.h
@@ -46,8 +46,9 @@ class ChromeClientImpl;
class DateTimeChooserImpl FINAL : public WebCore::DateTimeChooser, public WebCore::PagePopupClient {
public:
- static PassRefPtr<DateTimeChooserImpl> create(ChromeClientImpl*, WebCore::DateTimeChooserClient*, const WebCore::DateTimeChooserParameters&);
+ static PassRefPtrWillBeRawPtr<DateTimeChooserImpl> create(ChromeClientImpl*, WebCore::DateTimeChooserClient*, const WebCore::DateTimeChooserParameters&);
virtual ~DateTimeChooserImpl();
+ virtual void trace(WebCore::Visitor*) OVERRIDE;
// DateTimeChooser functions:
virtual void endChooser() OVERRIDE;
@@ -64,7 +65,7 @@ private:
virtual void didClosePopup() OVERRIDE;
ChromeClientImpl* m_chromeClient;
haraken 2014/06/05 04:59:25 Just to confirm: This raw pointer is safe because
keishi 2014/06/05 08:06:39 Yes.
- WebCore::DateTimeChooserClient* m_client;
+ RawPtrWillBeMember<WebCore::DateTimeChooserClient> m_client;
WebCore::PagePopup* m_popup;
haraken 2014/06/05 04:59:25 This raw pointer looks safe since it's explicitly
WebCore::DateTimeChooserParameters m_parameters;
OwnPtr<WebCore::Locale> m_locale;

Powered by Google App Engine
This is Rietveld 408576698