Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: Source/core/html/shadow/PickerIndicatorElement.cpp

Issue 275043002: Oilpan: Prepare moving DateTimeChooser to Oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/shadow/PickerIndicatorElement.cpp
diff --git a/Source/core/html/shadow/PickerIndicatorElement.cpp b/Source/core/html/shadow/PickerIndicatorElement.cpp
index 7c9806dc39802e6876d33b13fbd3904840fd5730..94a5123c7bdae4ca85bb600784d7244be2341543 100644
--- a/Source/core/html/shadow/PickerIndicatorElement.cpp
+++ b/Source/core/html/shadow/PickerIndicatorElement.cpp
@@ -62,8 +62,6 @@ PassRefPtrWillBeRawPtr<PickerIndicatorElement> PickerIndicatorElement::create(Do
PickerIndicatorElement::~PickerIndicatorElement()
{
- closePopup();
- ASSERT(!m_chooser);
haraken 2014/06/05 04:59:25 Shall we leave this ASSERT in non-oilpan builds? I
keishi 2014/06/05 08:06:39 This ASSERT is working because PickerIndicatorElem
}
RenderObject* PickerIndicatorElement::createRenderer(RenderStyle*)
@@ -154,7 +152,9 @@ bool PickerIndicatorElement::isPickerIndicatorElement() const
void PickerIndicatorElement::trace(Visitor* visitor)
{
visitor->trace(m_pickerIndicatorOwner);
+ visitor->trace(m_chooser);
HTMLDivElement::trace(visitor);
+ DateTimeChooserClient::trace(visitor);
}
}

Powered by Google App Engine
This is Rietveld 408576698