Source/web/DateTimeChooserImpl.h - Issue 275043002: Oilpan: Prepare moving DateTimeChooser to Oilpan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/DateTimeChooserImpl.h

Issue 275043002: Oilpan: Prepare moving DateTimeChooser to Oilpan (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/DateTimeChooserImpl.h

diff --git a/Source/web/DateTimeChooserImpl.h b/Source/web/DateTimeChooserImpl.h

index f43b3d41f6e08c716c480c38813c06ebdf459cae..f30b7b70f69d6a715145a1939d196d58d681d4fd 100644

--- a/Source/web/DateTimeChooserImpl.h

+++ b/Source/web/DateTimeChooserImpl.h

@@ -46,8 +46,9 @@ class ChromeClientImpl;

class DateTimeChooserImpl FINAL : public WebCore::DateTimeChooser, public WebCore::PagePopupClient {

public:

- static PassRefPtr<DateTimeChooserImpl> create(ChromeClientImpl*, WebCore::DateTimeChooserClient*, const WebCore::DateTimeChooserParameters&);

+ static PassRefPtrWillBeRawPtr<DateTimeChooserImpl> create(ChromeClientImpl*, WebCore::DateTimeChooserClient*, const WebCore::DateTimeChooserParameters&);

virtual ~DateTimeChooserImpl();

+ virtual void trace(WebCore::Visitor*) OVERRIDE;

zerny-chromium 2014/06/02 13:32:42 Nit: You can omit the trace method from this defin

// DateTimeChooser functions:

virtual void endChooser() OVERRIDE;

« Source/core/loader/EmptyClients.cpp ('K') | « Source/web/ChromeClientImpl.cpp ('k') | Source/web/DateTimeChooserImpl.cpp » ('j') | no next file with comments »