Oilpan: Prepare moving DateTimeChooser to Oilpan

Source/platform/DateTimeChooserClient.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef DateTimeChooserClient_h
 #define DateTimeChooserClient_h
 
 #include "platform/PlatformExport.h"
+#include "platform/heap/Handle.h"
 #include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
-class PLATFORM_EXPORT DateTimeChooserClient {
+class PLATFORM_EXPORT DateTimeChooserClient : public WillBeGarbageCollectedMixin {

[sof, 2014/06/14 06:18:01]

This subtly breaks the non-Oilpan component build, as it will instantiate
WebCore::DummyBase<void> in blink_platform _and_ implicitly export the derived
template instantiation (at least MSVC does, see
http://msdn.microsoft.com/en-us/library/twa2aw10.aspx 's last bullet point.) The
linker will then complain when it links blink_web, as it also has that
instantiation.

The best solution I could come up with was to let that DummyBase instantiation
be exported from blink_platform & have everyone else import it, see
https://codereview.chromium.org/302093011/patch/80001/90008. There are some
relevant comments on that review as well, I think. That CL is not going ahead,
so feel free to re-purpose :)

+    DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(DateTimeChooserClient);
 public:
-    virtual ~DateTimeChooserClient();
-
     // Called when user picked a value.
     virtual void didChooseValue(const String&) = 0;
     // Called when user picked a value.
     virtual void didChooseValue(double) = 0;
     // Called when chooser has ended.
     virtual void didEndChooser() = 0;
+
+    virtual void trace(Visitor*) { }
 };
 
 } // namespace WebCore
 #endif // DateTimeChooserClient_h