Issue 2750393003: Fix FutureOr runtime check

Issue 2750393003: Fix FutureOr runtime check (Closed)

Created:
3 years, 9 months ago by vsm

Modified:
3 years, 9 months ago

Reviewers:
keertip, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+148 lines, -136 lines)			Patch
M	pkg/dev_compiler/lib/sdk/ddc_sdk.sum	View	Binary file		0 comments	Download
M	pkg/dev_compiler/test/codegen_expected/map_keys.js.map	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js.map	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart	View	3 chunks	+29 lines, -17 lines	0 comments	Download
M	pkg/dev_compiler/tool/sdk_expected_errors.txt	View	3 chunks	+117 lines, -117 lines	0 comments	Download

Total messages: 7 (3 generated)

Jennifer Messerly

LGTM, thanks Vijay! also you can mark this as fixing https://github.com/dart-lang/sdk/issues/29062

3 years, 9 months ago (2017-03-16 19:48:26 UTC) #4

Jennifer Messerly

On 2017/03/16 19:48:26, Jennifer Messerly wrote: > LGTM, thanks Vijay! also you can mark this ...

3 years, 9 months ago (2017-03-16 19:48:44 UTC) #5

vsm

3 years, 9 months ago (2017-03-16 19:54:35 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2fd1f5ebf1bc8066a473da68743c2815b50f3323 (presubmit successful).