Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Side by Side Diff: ios/web/webui/mojo_facade.mm

Issue 2750373002: Revert of Mojo: Armed Watchers (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/web/webui/mojo_facade.h ('k') | ios/web/webui/mojo_facade_unittest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/webui/mojo_facade.h" 5 #import "ios/web/webui/mojo_facade.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #import <Foundation/Foundation.h> 9 #import <Foundation/Foundation.h>
10 10
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 245
246 std::unique_ptr<base::Value> MojoFacade::HandleSupportWatch( 246 std::unique_ptr<base::Value> MojoFacade::HandleSupportWatch(
247 const base::DictionaryValue* args) { 247 const base::DictionaryValue* args) {
248 int handle = 0; 248 int handle = 0;
249 CHECK(args->GetInteger("handle", &handle)); 249 CHECK(args->GetInteger("handle", &handle));
250 int signals = 0; 250 int signals = 0;
251 CHECK(args->GetInteger("signals", &signals)); 251 CHECK(args->GetInteger("signals", &signals));
252 int callback_id; 252 int callback_id;
253 CHECK(args->GetInteger("callbackId", &callback_id)); 253 CHECK(args->GetInteger("callbackId", &callback_id));
254 254
255 mojo::SimpleWatcher::ReadyCallback callback = base::BindBlockArc(^( 255 mojo::Watcher::ReadyCallback callback = base::BindBlockArc(^(
256 MojoResult result) { 256 MojoResult result) {
257 NSString* script = 257 NSString* script =
258 [NSString stringWithFormat:@"__crWeb.mojo.signalWatch(%d, %d)", 258 [NSString stringWithFormat:@"__crWeb.mojo.signalWatch(%d, %d)",
259 callback_id, result]; 259 callback_id, result];
260 [script_evaluator_ executeJavaScript:script completionHandler:nil]; 260 [script_evaluator_ executeJavaScript:script completionHandler:nil];
261 }); 261 });
262 mojo::SimpleWatcher* watcher = new mojo::SimpleWatcher( 262 mojo::Watcher* watcher = new mojo::Watcher(FROM_HERE);
263 FROM_HERE, mojo::SimpleWatcher::ArmingPolicy::AUTOMATIC);
264 watchers_.insert(std::make_pair(++last_watch_id_, base::WrapUnique(watcher))); 263 watchers_.insert(std::make_pair(++last_watch_id_, base::WrapUnique(watcher)));
265 watcher->Watch(static_cast<mojo::Handle>(handle), signals, callback); 264 watcher->Start(static_cast<mojo::Handle>(handle), signals, callback);
266 return ValueFromInteger(last_watch_id_); 265 return ValueFromInteger(last_watch_id_);
267 } 266 }
268 267
269 std::unique_ptr<base::Value> MojoFacade::HandleSupportCancelWatch( 268 std::unique_ptr<base::Value> MojoFacade::HandleSupportCancelWatch(
270 const base::DictionaryValue* args) { 269 const base::DictionaryValue* args) {
271 int watch_id = 0; 270 int watch_id = 0;
272 CHECK(args->GetInteger("watchId", &watch_id)); 271 CHECK(args->GetInteger("watchId", &watch_id));
273 watchers_.erase(watch_id); 272 watchers_.erase(watch_id);
274 return nullptr; 273 return nullptr;
275 } 274 }
276 275
277 } // namespace web 276 } // namespace web
OLDNEW
« no previous file with comments | « ios/web/webui/mojo_facade.h ('k') | ios/web/webui/mojo_facade_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698