Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Issue 2750353003: Compute ids for IR nodes and check equivalence with the AST. (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute ids for IR nodes and check equivalence with the AST. This creates a basis for checking type inference based on kernel IR against the unittests for the original AST based implementation. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/d29c4e2256a2f904ad3b8c7c70b5484255db81dc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -10 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/inference/enumerator.dart View 2 chunks +134 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/inference/id_equivalence_test.dart View 1 chunk +73 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/inference/inference_test_helper.dart View 1 4 chunks +34 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/inference/send_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-16 15:03:48 UTC) #2
Emily Fortuna
lgtm https://codereview.chromium.org/2750353003/diff/1/tests/compiler/dart2js/inference/inference_test_helper.dart File tests/compiler/dart2js/inference/inference_test_helper.dart (right): https://codereview.chromium.org/2750353003/diff/1/tests/compiler/dart2js/inference/inference_test_helper.dart#newcode52 tests/compiler/dart2js/inference/inference_test_helper.dart:52: "Unfound ids: $expectedMap."); nit: "Unfound" -> "Not found"
3 years, 9 months ago (2017-03-16 17:34:31 UTC) #3
Johnni Winther
https://codereview.chromium.org/2750353003/diff/1/tests/compiler/dart2js/inference/inference_test_helper.dart File tests/compiler/dart2js/inference/inference_test_helper.dart (right): https://codereview.chromium.org/2750353003/diff/1/tests/compiler/dart2js/inference/inference_test_helper.dart#newcode52 tests/compiler/dart2js/inference/inference_test_helper.dart:52: "Unfound ids: $expectedMap."); On 2017/03/16 17:34:30, Emily Fortuna wrote: ...
3 years, 9 months ago (2017-03-17 08:43:53 UTC) #4
Johnni Winther
3 years, 9 months ago (2017-03-17 08:50:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d29c4e2256a2f904ad3b8c7c70b5484255db81dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698