Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Unified Diff: components/autofill/content/renderer/form_cache.cc

Issue 2750323003: [Password Manager] Replace WebInputElement.setValue with WebInputElement.setAutofillValue (Closed)
Patch Set: Fixed Win tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/form_cache.cc
diff --git a/components/autofill/content/renderer/form_cache.cc b/components/autofill/content/renderer/form_cache.cc
index 03cb04f47cd2650ccbe5959cdea898b03e9a3265..00ddb78ff18e8bfcd0cb729836e103f783dd50ff 100644
--- a/components/autofill/content/renderer/form_cache.cc
+++ b/components/autofill/content/renderer/form_cache.cc
@@ -210,7 +210,7 @@ bool FormCache::ClearFormWithElement(const WebFormControlElement& element) {
WebInputElement* input_element = toWebInputElement(&control_element);
if (form_util::IsTextInput(input_element) ||
form_util::IsMonthInput(input_element)) {
- input_element->setValue(blink::WebString(), true);
+ input_element->setAutofillValue(blink::WebString());
// Clearing the value in the focused node (above) can cause selection
// to be lost. We force selection range to restore the text cursor.
@@ -219,7 +219,7 @@ bool FormCache::ClearFormWithElement(const WebFormControlElement& element) {
input_element->setSelectionRange(length, length);
}
} else if (form_util::IsTextAreaElement(control_element)) {
- control_element.setValue(blink::WebString(), true);
+ control_element.setAutofillValue(blink::WebString());
} else if (form_util::IsSelectElement(control_element)) {
WebSelectElement select_element = control_element.to<WebSelectElement>();
@@ -227,8 +227,8 @@ bool FormCache::ClearFormWithElement(const WebFormControlElement& element) {
initial_value_iter = initial_select_values_.find(select_element);
if (initial_value_iter != initial_select_values_.end() &&
select_element.value().utf16() != initial_value_iter->second) {
- select_element.setValue(
- blink::WebString::fromUTF16(initial_value_iter->second), true);
+ select_element.setAutofillValue(
+ blink::WebString::fromUTF16(initial_value_iter->second));
}
} else {
WebInputElement input_element = control_element.to<WebInputElement>();

Powered by Google App Engine
This is Rietveld 408576698