Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2750323003: [Password Manager] Replace WebInputElement.setValue with WebInputElement.setAutofillValue (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index abac9479d637fa6a8995b68284d83cbf1251bc6c..ced3e1285e0b62b5b444aabde195aa1551722bf3 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -456,7 +456,7 @@ bool FillUserNameAndPassword(
if (!username_element->isNull() &&
IsElementAutocompletable(*username_element)) {
// TODO(crbug.com/507714): Why not setSuggestedValue?
- username_element->setValue(blink::WebString::fromUTF16(username), true);
+ username_element->setAutofillValue(blink::WebString::fromUTF16(username));
UpdateFieldValueAndPropertiesMaskMap(*username_element, &username,
FieldPropertiesFlags::AUTOFILLED,
field_value_and_properties_map);
@@ -551,8 +551,8 @@ bool FillFormOnPasswordReceived(
if (form_has_fillable_username && username_element.value().isEmpty()) {
// TODO(tkent): Check maxlength and pattern.
- username_element.setValue(
- blink::WebString::fromUTF16(fill_data.username_field.value), true);
+ username_element.setAutofillValue(
+ blink::WebString::fromUTF16(fill_data.username_field.value));
}
// Fill if we have an exact match for the username. Note that this sets
@@ -656,7 +656,7 @@ void PasswordAutofillAgent::PasswordValueGatekeeper::Reset() {
void PasswordAutofillAgent::PasswordValueGatekeeper::ShowValue(
blink::WebInputElement* element) {
if (!element->isNull() && !element->suggestedValue().isEmpty())
- element->setValue(element->suggestedValue(), true);
+ element->setAutofillValue(element->suggestedValue());
}
bool PasswordAutofillAgent::TextDidChangeInTextField(
@@ -748,14 +748,14 @@ bool PasswordAutofillAgent::FillSuggestion(
password_info->password_field = password_element;
} else if (!username_element.isNull() &&
IsElementAutocompletable(username_element)) {
- username_element.setValue(blink::WebString::fromUTF16(username), true);
+ username_element.setAutofillValue(blink::WebString::fromUTF16(username));
username_element.setAutofilled(true);
UpdateFieldValueAndPropertiesMaskMap(username_element, &username,
FieldPropertiesFlags::AUTOFILLED,
&field_value_and_properties_map_);
}
- password_element.setValue(blink::WebString::fromUTF16(password), true);
+ password_element.setAutofillValue(blink::WebString::fromUTF16(password));
password_element.setAutofilled(true);
UpdateFieldValueAndPropertiesMaskMap(password_element, &password,
FieldPropertiesFlags::AUTOFILLED,

Powered by Google App Engine
This is Rietveld 408576698