[Password Manager] Replace WebInputElement.setValue with WebInputElement.setAutofillValue

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 159 matching lines @@
 const char kJavaScriptClick[] =
     "var event = new MouseEvent('click', {"
     "   'view': window,"
     "   'bubbles': true,"
     "   'cancelable': true"
     "});"
     "var form = document.getElementById('myform1');"
     "form.dispatchEvent(event);"
     "console.log('clicked!');";
 
-const char kOnChangeDetectionScript[] =
-    "<script>"
-    "  usernameOnchangeCalled = false;"
-    "  passwordOnchangeCalled = false;"
-    "  document.getElementById('username').onchange = function() {"
-    "    usernameOnchangeCalled = true;"
-    "  };"
-    "  document.getElementById('password').onchange = function() {"
-    "    passwordOnchangeCalled = true;"
-    "  };"
-    "</script>";
-
 const char kFormHTMLWithTwoTextFields[] =
     "<FORM name='LoginTestForm' id='LoginTestForm' "
     "action='http://www.bidule.com'>"
     "  <INPUT type='text' id='username'/>"
     "  <INPUT type='text' id='email'/>"
     "  <INPUT type='password' id='password'/>"
     "  <INPUT type='submit' value='Login'/>"
     "</FORM>";
 
 const char kPasswordChangeFormHTML[] =
@@ skipping 342 matching lines @@
     ASSERT_TRUE(fake_driver_.called_inpage_navigation());
     ASSERT_TRUE(
         static_cast<bool>(fake_driver_.password_form_inpage_navigation()));
     const autofill::PasswordForm& form =
         *(fake_driver_.password_form_inpage_navigation());
     EXPECT_EQ(ASCIIToUTF16(username_value), form.username_value);
     EXPECT_EQ(ASCIIToUTF16(password_value), form.password_value);
     EXPECT_EQ(ASCIIToUTF16(new_password_value), form.new_password_value);
   }
 
+  void CheckIfEventsAreCalled(const std::vector<std::string> checkers,

[vabr (Chromium), 2017/03/17 12:01:06]

Please pass the vector by (const) reference, not by value.

[kolos1, 2017/03/17 12:47:36]

Done.

+                              bool expected) {
+    for (const std::string& variable : checkers) {
+      int value;
+      EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(
+          base::UTF8ToUTF16(variable), &value))
+          << variable;
+      EXPECT_EQ(expected, value == 1) << variable;
+    }
+  }
+
   bool GetCalledShowPasswordGenerationPopup() {
     fake_pw_client_.Flush();
     return fake_pw_client_.called_show_pw_generation_popup();
   }
 
   void BindPasswordManagerDriver(mojo::ScopedMessagePipeHandle handle) {
     fake_driver_.BindRequest(
         mojo::MakeRequest<mojom::PasswordManagerDriver>(std::move(handle)));
   }
 
@@ skipping 348 matching lines @@
   SimulateOnFillPasswordForm(fill_data_);
 
   ExecuteJavaScriptForTests(kJavaScriptClick);
   CheckTextFieldsDOMState(kAliceUsername, true, "", true);
 }
 
 // Verifies that password autofill triggers onChange events in JavaScript for
 // forms that are filled on page load.
 TEST_F(PasswordAutofillAgentTest,
        PasswordAutofillTriggersOnChangeEventsOnLoad) {
-  std::string html = std::string(kFormHTML) + kOnChangeDetectionScript;
+  std::string html = std::string(kFormHTML);
   LoadHTML(html.c_str());
   UpdateOriginForHTML(html);
   UpdateUsernameAndPasswordElements();
 
+  std::vector<std::string> username_event_checkers;
+  std::vector<std::string> password_event_checkers;
+  std::string events_registration_script =
+      CreateScriptToRegisterListeners(kUsernameName, &username_event_checkers) +
+      CreateScriptToRegisterListeners(kPasswordName, &password_event_checkers);
+  ExecuteJavaScriptForTests(events_registration_script.c_str());
+
   // Simulate the browser sending back the login info, it triggers the
   // autocomplete.
   SimulateOnFillPasswordForm(fill_data_);
 
   // The username and password should have been autocompleted...
   CheckTextFieldsState(kAliceUsername, true, kAlicePassword, true);
   // ... but since there hasn't been a user gesture yet, the autocompleted
   // password should only be visible to the user.
   CheckTextFieldsDOMState(kAliceUsername, true, std::string(), true);
 
   // A JavaScript onChange event should have been triggered for the username,
   // but not yet for the password.
-  int username_onchange_called = -1;
-  int password_onchange_called = -1;
-  ASSERT_TRUE(
-      ExecuteJavaScriptAndReturnIntValue(
-          ASCIIToUTF16("usernameOnchangeCalled ? 1 : 0"),
-          &username_onchange_called));
-  EXPECT_EQ(1, username_onchange_called);
-  ASSERT_TRUE(
-      ExecuteJavaScriptAndReturnIntValue(
-          ASCIIToUTF16("passwordOnchangeCalled ? 1 : 0"),
-          &password_onchange_called));
+
+  CheckIfEventsAreCalled(username_event_checkers, true);
   // TODO(isherman): Re-enable this check once http://crbug.com/333144 is fixed.

[vabr (Chromium), 2017/03/17 12:01:07]

This comment looks obsoleted by your changes.

[kolos1, 2017/03/17 12:47:36]

Done.

-  // EXPECT_EQ(0, password_onchange_called);
+  CheckIfEventsAreCalled(password_event_checkers, false);
 
   // Simulate a user click so that the password field's real value is filled.
   SimulateElementClick(kUsernameName);
   CheckTextFieldsDOMState(kAliceUsername, true, kAlicePassword, true);
 
   // Now, a JavaScript onChange event should have been triggered for the
   // password as well.
-  ASSERT_TRUE(
-      ExecuteJavaScriptAndReturnIntValue(
-          ASCIIToUTF16("passwordOnchangeCalled ? 1 : 0"),
-          &password_onchange_called));
-  EXPECT_EQ(1, password_onchange_called);
+  CheckIfEventsAreCalled(password_event_checkers, true);
 }
 
 // Verifies that password autofill triggers onChange events in JavaScript for
 // forms that are filled after page load.
 TEST_F(PasswordAutofillAgentTest,
        PasswordAutofillTriggersOnChangeEventsWaitForUsername) {
-  std::string html = std::string(kFormHTML) + kOnChangeDetectionScript;
+  std::string html = std::string(kFormHTML);
   LoadHTML(html.c_str());
   UpdateOriginForHTML(html);
   UpdateUsernameAndPasswordElements();
 
+  std::vector<std::string> event_checkers;
+  std::string events_registration_script =
+      CreateScriptToRegisterListeners(kUsernameName, &event_checkers) +
+      CreateScriptToRegisterListeners(kPasswordName, &event_checkers);
+  ExecuteJavaScriptForTests(events_registration_script.c_str());
+
   // Simulate the browser sending back the login info, it triggers the
   // autocomplete.
   fill_data_.wait_for_username = true;
   SimulateOnFillPasswordForm(fill_data_);
 
   // The username and password should not yet have been autocompleted.
   CheckTextFieldsState(std::string(), false, std::string(), false);
 
   // Simulate a click just to force a user gesture, since the username value is
   // set directly.
   SimulateElementClick(kUsernameName);
 
   // Simulate the user entering the first letter of their username and selecting
   // the matching autofill from the dropdown.
   SimulateUsernameChange("a");
+  // Since the username element has focus, blur event will ne be triggered.
+  event_checkers.erase(std::remove(event_checkers.begin(), event_checkers.end(),

[vabr (Chromium), 2017/03/17 12:01:06]

Please use base::Erase instead (this is a recent change in style, there was a
discussion on chromium-dev a few days ago).

[kolos1, 2017/03/17 12:47:36]

Done.

+                                   "username_blur_event"),
+                       event_checkers.end());
   SimulateSuggestionChoice(username_element_);
 
   // The username and password should now have been autocompleted.
   CheckTextFieldsDOMState(kAliceUsername, true, kAlicePassword, true);
 
   // JavaScript onChange events should have been triggered both for the username
   // and for the password.
-  int username_onchange_called = -1;
-  int password_onchange_called = -1;
-  ASSERT_TRUE(
-      ExecuteJavaScriptAndReturnIntValue(
-          ASCIIToUTF16("usernameOnchangeCalled ? 1 : 0"),
-          &username_onchange_called));
-  EXPECT_EQ(1, username_onchange_called);
-  ASSERT_TRUE(
-      ExecuteJavaScriptAndReturnIntValue(
-          ASCIIToUTF16("passwordOnchangeCalled ? 1 : 0"),
-          &password_onchange_called));
-  EXPECT_EQ(1, password_onchange_called);
+  CheckIfEventsAreCalled(event_checkers, true);
 }
 
 // Tests that |FillSuggestion| properly fills the username and password.
 TEST_F(PasswordAutofillAgentTest, FillSuggestion) {
   // Simulate the browser sending the login info, but set |wait_for_username|
   // to prevent the form from being immediately filled.
   fill_data_.wait_for_username = true;
   SimulateOnFillPasswordForm(fill_data_);
 
   // Neither field should have been autocompleted.
@@ skipping 1512 matching lines @@
   SimulateElementClick(kUsernameName);
 
   // Simulate a user clicking on the password element. This should produce a
   // dropdown with suggestion of all available usernames.
   static_cast<PageClickListener*>(autofill_agent_)
       ->FormControlElementClicked(password_element_, false);
   CheckSuggestions("", false);
 }
 
 }  // namespace autofill