Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: components/history/core/browser/history_service.cc

Issue 2750313002: Extend HistoryService with support for favicons from Google servers (Closed)
Patch Set: Rename function. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/history/core/browser/history_service.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/history_service.cc
diff --git a/components/history/core/browser/history_service.cc b/components/history/core/browser/history_service.cc
index 081e5cdd08cfeddf9c1e50269963a264bc69073c..c08242884054a6cf783e27c7ce5b332b3f6cb010 100644
--- a/components/history/core/browser/history_service.cc
+++ b/components/history/core/browser/history_service.cc
@@ -621,6 +621,24 @@ void HistoryService::SetFavicons(const GURL& page_url,
page_url, icon_type, icon_url, bitmaps));
}
+void HistoryService::SetLastResortFavicons(
+ const GURL& page_url,
+ favicon_base::IconType icon_type,
+ const GURL& icon_url,
+ const std::vector<SkBitmap>& bitmaps,
+ base::Callback<void(bool)> callback) {
+ DCHECK(backend_task_runner_) << "History service being called after cleanup";
+ DCHECK(thread_checker_.CalledOnValidThread());
+ if (history_client_ && !history_client_->CanAddURL(page_url))
+ return;
+
+ PostTaskAndReplyWithResult(
+ FROM_HERE,
+ base::Bind(&HistoryBackend::SetLastResortFavicons, history_backend_,
+ page_url, icon_type, icon_url, bitmaps),
+ callback);
+}
+
void HistoryService::SetFaviconsOutOfDateForPage(const GURL& page_url) {
DCHECK(backend_task_runner_) << "History service being called after cleanup";
DCHECK(thread_checker_.CalledOnValidThread());
« no previous file with comments | « components/history/core/browser/history_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698