src/typing.cc - Issue 27503002: Fix lower bound of shr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 27503002: Fix lower bound of shr. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index c3fd9c0142c3e112b00739ed1d3b4589230485ad..87e3a6e3392408e5c4a123e0337d5d29e5574246 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -604,7 +604,7 @@ void AstTyper::VisitBinaryOperation(BinaryOperation* expr) {

RECURSE(Visit(expr->left()));

RECURSE(Visit(expr->right()));

// TODO(rossberg): we could use an UnsignedSmi as lower bound here...

- NarrowType(expr, Bounds(Type::Unsigned32(), isolate_));

+ NarrowType(expr, Bounds(Type::Smi(), Type::Number(), isolate_));

break;

case Token::ADD: {

RECURSE(Visit(expr->left()));

« no previous file with comments | « no previous file | no next file » | no next file with comments »