Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 275026: Move scripting / v8 related methods out of WebKit.h, second try (Closed)

Created:
11 years, 2 months ago by Mohamed Mansour
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move scripting / v8 related methods out of WebKit.h BUG=24602 TEST=Compiled Webkit/Chromium Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29245

Patch Set 1 : Move scripting / v8 related methods out of WebKit.h #

Total comments: 1

Patch Set 2 : Missing include #

Patch Set 3 : Mofiy webkit.gyp aRRG #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -54 lines) Patch
M chrome/renderer/render_thread.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/render_view_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/api/public/WebKit.h View 2 chunks +0 lines, -26 lines 0 comments Download
A webkit/api/public/WebScriptController.h View 1 chunk +67 lines, -0 lines 0 comments Download
M webkit/api/src/WebKit.cpp View 3 chunks +0 lines, -28 lines 0 comments Download
A webkit/api/src/WebScriptController.cpp View 1 1 chunk +67 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/webkit.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mohamed Mansour
Created WebScriptController as Adam mentioned in the tracker, and moved out the methods that Darin ...
11 years, 2 months ago (2009-10-15 06:16:19 UTC) #1
abarth-chromium
LGTM, but Darin is the WebKit API expert.
11 years, 2 months ago (2009-10-15 06:23:59 UTC) #2
Mohamed Mansour
On 2009/10/15 06:23:59, abarth wrote: > LGTM, but Darin is the WebKit API expert. Strange, ...
11 years, 2 months ago (2009-10-15 06:36:36 UTC) #3
darin (slow to review)
11 years, 2 months ago (2009-10-15 07:01:39 UTC) #4
Nice, thank you!!  Just one nit, and then LGTM.

http://codereview.chromium.org/275026/diff/20/2006
File webkit/api/src/WebScriptController.cpp (right):

http://codereview.chromium.org/275026/diff/20/2006#newcode31
Line 31: #include "WebScriptController.h"
nit: please #include "config.h" above this one.

(all .cpp files in the WebKit API should include config.h, just like all .cpp
files in WebCore.)

Powered by Google App Engine
This is Rietveld 408576698