third_party/WebKit/Source/core/layout/ng/ng_line_builder.h - Issue 2750213002: [LayoutNG] Don't pass parent NGFragmentBuilder into NGLineBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

Issue 2750213002: [LayoutNG] Don't pass parent NGFragmentBuilder into NGLineBuilder. (Closed)

Patch Set: rebase fix. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

index af94ebd916163bc77f3a5fd098e8dfe608b1ca9c..823269def4d630f2b7b01c7ab96c7d8bdaeb6ed6 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.h

@@ -31,7 +31,7 @@ class CORE_EXPORT NGLineBuilder final {

STACK_ALLOCATED();

public:

- NGLineBuilder(NGInlineNode*, NGConstraintSpace*, NGFragmentBuilder*);

+ NGLineBuilder(NGInlineNode*, NGConstraintSpace*);

const NGConstraintSpace& ConstraintSpace() const {

return *constraint_space_;

@@ -159,7 +159,6 @@ class CORE_EXPORT NGLineBuilder final {

Persistent<NGInlineNode> inline_box_;

NGConstraintSpace* constraint_space_; // Not owned as STACK_ALLOCATED.

- NGFragmentBuilder* containing_block_builder_;

Vector<RefPtr<NGLayoutResult>, 32> layout_results_;

Vector<LineBoxData, 32> line_box_data_list_;

unsigned start_index_ = 0;