Android perf tests: only store the retry results if it's better.

Android perf tests: only store the retry results if it's better.

Rather than blindingly store the results of the latest perf test,
keep the "least worst" run.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229351

[bulach, 2013-10-16 11:52:23]

ptal

[Dominik Grewe, 2013-10-16 13:51:43]

LGTM with two minor comments.

https://codereview.chromium.org/27502002/diff/1/build/android/pylib/perf/test...
File build/android/pylib/perf/test_runner.py (right):

https://codereview.chromium.org/27502002/diff/1/build/android/pylib/perf/test...
build/android/pylib/perf/test_runner.py:5: """Runs a perf test on a single
device.
Is this still accurate? According to the comment below we're running the tests
across multiple devices. Or am I missing something?

https://codereview.chromium.org/27502002/diff/1/build/android/pylib/perf/test...
build/android/pylib/perf/test_runner.py:50: import re
Is this needed for anything?

[bulach, 2013-10-16 17:03:00]

thanks! all addressed, CQing..

https://codereview.chromium.org/27502002/diff/1/build/android/pylib/perf/test...
File build/android/pylib/perf/test_runner.py (right):

https://codereview.chromium.org/27502002/diff/1/build/android/pylib/perf/test...
build/android/pylib/perf/test_runner.py:5: """Runs a perf test on a single
device.
On 2013/10/16 13:51:43, Dominik Grewe wrote:
> Is this still accurate? According to the comment below we're running the tests
> across multiple devices. Or am I missing something?

good point! fixed..

https://codereview.chromium.org/27502002/diff/1/build/android/pylib/perf/test...
build/android/pylib/perf/test_runner.py:50: import re
On 2013/10/16 13:51:43, Dominik Grewe wrote:
> Is this needed for anything?

nope, removed..

[commit-bot: I haz the power, 2013-10-16 17:04:28]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bulach, 2013-10-17 09:01:17]

+rmcilroy

[rmcilroy, 2013-10-17 10:22:15]

lgtm

[commit-bot: I haz the power, 2013-10-17 11:06:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/27502002/8001

[commit-bot: I haz the power, 2013-10-17 13:14:19]

Retried try job too often on mac_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-10-17 13:19:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/27502002/8001

[commit-bot: I haz the power, 2013-10-17 16:35:14]

Retried try job too often on win_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-17 16:46:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/27502002/8001

[commit-bot: I haz the power, 2013-10-18 01:43:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/27502002/8001

[commit-bot: I haz the power, 2013-10-18 11:03:56]

Change committed as 229351