Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2750193002: Fix for issue 28854. (Closed)

Created:
3 years, 9 months ago by siva
Modified:
3 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Adjust format. #

Patch Set 3 : Address self review comments. #

Patch Set 4 : Adjust status file for dartium as the test will fail because Isolate.spawn is used. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -15 lines) Patch
M runtime/vm/snapshot.cc View 1 2 3 3 chunks +21 lines, -15 lines 0 comments Download
A tests/standalone/regress_28854_1_test.dart View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A tests/standalone/regress_28854_2_test.dart View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
3 years, 9 months ago (2017-03-16 02:12:46 UTC) #2
rmacnak
lgtm
3 years, 9 months ago (2017-03-16 20:57:08 UTC) #3
siva
3 years, 9 months ago (2017-03-16 23:44:43 UTC) #4
siva
3 years, 9 months ago (2017-03-16 23:53:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
1133a4dc2c342312ab6aa5c4383282117722d27b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698