Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

Issue 2750153002: getClientRects() shouldn't clip against any ancestors. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp b/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp
index 3d5310931846e5443c88bdd45413c4d0896a43ca..61bf57342b747e37f89529154dceaeed0e3007cd 100644
--- a/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp
@@ -139,7 +139,9 @@ void LayoutFlowThread::absoluteQuadsForDescendant(const LayoutBox& descendant,
LayoutRect fragment = boundingRectInFlowThread;
// We use inclusiveIntersect() because intersect() would reset the
// coordinates for zero-height objects.
- fragment.inclusiveIntersect(iterator.fragmentainerInFlowThread());
+ LayoutRect clipRect = iterator.clipRectInFlowThread(
+ MultiColumnFragmentainerGroup::BlockDirectionAxis);
+ fragment.inclusiveIntersect(clipRect);
fragment.moveBy(-offsetFromFlowThread);
quads.push_back(descendant.localToAbsoluteQuad(FloatRect(fragment), mode));
}

Powered by Google App Engine
This is Rietveld 408576698