Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js

Issue 2750103002: DevTools: update debugger sidepane style for paused on exception (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js b/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js
index 0fa179c36491c88ed67336129edadbc0a02a4393..89f458a2a0c974ebdf5239351e9f409fd8a88225 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js
@@ -30,6 +30,9 @@ Sources.DebuggerPausedMessage = class {
if (!details)
return;
+ var errorLike = details.reason === SDK.DebuggerModel.BreakReason.Exception ||
+ details.reason === SDK.DebuggerModel.BreakReason.PromiseRejection ||
+ details.reason === SDK.DebuggerModel.BreakReason.Assert || details.reason === SDK.DebuggerModel.BreakReason.OOM;
var messageWrapper;
if (details.reason === SDK.DebuggerModel.BreakReason.DOM) {
messageWrapper = Components.DOMBreakpointsSidebarPane.createBreakpointHitMessage(details);
@@ -65,9 +68,6 @@ Sources.DebuggerPausedMessage = class {
'ScriptsPanel paused, but callFrames.length is zero.'); // TODO remove this once we understand this case better
}
- var errorLike = details.reason === SDK.DebuggerModel.BreakReason.Exception ||
- details.reason === SDK.DebuggerModel.BreakReason.PromiseRejection ||
- details.reason === SDK.DebuggerModel.BreakReason.Assert || details.reason === SDK.DebuggerModel.BreakReason.OOM;
status.classList.toggle('error-reason', errorLike);
if (messageWrapper)
status.appendChild(messageWrapper);
@@ -81,14 +81,16 @@ Sources.DebuggerPausedMessage = class {
function buildWrapper(mainText, subText, title) {
var messageWrapper = createElement('span');
var mainElement = messageWrapper.createChild('div', 'status-main');
- mainElement.appendChild(UI.Icon.create('smallicon-info', 'status-icon'));
+ var icon = UI.Icon.create(errorLike ? 'smallicon-error' : 'smallicon-info', 'status-icon');
+ mainElement.appendChild(icon);
mainElement.appendChild(createTextNode(mainText));
if (subText) {
var subElement = messageWrapper.createChild('div', 'status-sub monospace');
subElement.textContent = subText;
}
- if (title)
- messageWrapper.title = title;
+ var tooltip = title || subText;
+ if (tooltip)
+ messageWrapper.title = tooltip;
return messageWrapper;
}
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698