Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js

Issue 2750103002: DevTools: update debugger sidepane style for paused on exception (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Sources.DebuggerPausedMessage = class { 7 Sources.DebuggerPausedMessage = class {
8 constructor() { 8 constructor() {
9 this._element = createElementWithClass('div', 'paused-message flex-none'); 9 this._element = createElementWithClass('div', 'paused-message flex-none');
10 var root = UI.createShadowRootWithCoreStyles(this._element, 'sources/debugge rPausedMessage.css'); 10 var root = UI.createShadowRootWithCoreStyles(this._element, 'sources/debugge rPausedMessage.css');
(...skipping 12 matching lines...) Expand all
23 * @param {!Bindings.DebuggerWorkspaceBinding} debuggerWorkspaceBinding 23 * @param {!Bindings.DebuggerWorkspaceBinding} debuggerWorkspaceBinding
24 * @param {!Bindings.BreakpointManager} breakpointManager 24 * @param {!Bindings.BreakpointManager} breakpointManager
25 */ 25 */
26 render(details, debuggerWorkspaceBinding, breakpointManager) { 26 render(details, debuggerWorkspaceBinding, breakpointManager) {
27 var status = this._contentElement; 27 var status = this._contentElement;
28 status.hidden = !details; 28 status.hidden = !details;
29 status.removeChildren(); 29 status.removeChildren();
30 if (!details) 30 if (!details)
31 return; 31 return;
32 32
33 var errorLike = details.reason === SDK.DebuggerModel.BreakReason.Exception | |
34 details.reason === SDK.DebuggerModel.BreakReason.PromiseRejection ||
35 details.reason === SDK.DebuggerModel.BreakReason.Assert || details.reaso n === SDK.DebuggerModel.BreakReason.OOM;
33 var messageWrapper; 36 var messageWrapper;
34 if (details.reason === SDK.DebuggerModel.BreakReason.DOM) { 37 if (details.reason === SDK.DebuggerModel.BreakReason.DOM) {
35 messageWrapper = Components.DOMBreakpointsSidebarPane.createBreakpointHitM essage(details); 38 messageWrapper = Components.DOMBreakpointsSidebarPane.createBreakpointHitM essage(details);
36 } else if (details.reason === SDK.DebuggerModel.BreakReason.EventListener) { 39 } else if (details.reason === SDK.DebuggerModel.BreakReason.EventListener) {
37 var eventName = details.auxData['eventName']; 40 var eventName = details.auxData['eventName'];
38 var eventNameForUI = Sources.EventListenerBreakpointsSidebarPane.eventName ForUI(eventName, details.auxData); 41 var eventNameForUI = Sources.EventListenerBreakpointsSidebarPane.eventName ForUI(eventName, details.auxData);
39 messageWrapper = buildWrapper(Common.UIString('Paused on event listener'), eventNameForUI); 42 messageWrapper = buildWrapper(Common.UIString('Paused on event listener'), eventNameForUI);
40 } else if (details.reason === SDK.DebuggerModel.BreakReason.XHR) { 43 } else if (details.reason === SDK.DebuggerModel.BreakReason.XHR) {
41 messageWrapper = buildWrapper(Common.UIString('Paused on XMLHttpRequest'), details.auxData['url'] || ''); 44 messageWrapper = buildWrapper(Common.UIString('Paused on XMLHttpRequest'), details.auxData['url'] || '');
42 } else if (details.reason === SDK.DebuggerModel.BreakReason.Exception) { 45 } else if (details.reason === SDK.DebuggerModel.BreakReason.Exception) {
(...skipping 15 matching lines...) Expand all
58 var breakpoint = uiLocation ? 61 var breakpoint = uiLocation ?
59 breakpointManager.findBreakpoint(uiLocation.uiSourceCode, uiLocation.l ineNumber, uiLocation.columnNumber) : 62 breakpointManager.findBreakpoint(uiLocation.uiSourceCode, uiLocation.l ineNumber, uiLocation.columnNumber) :
60 null; 63 null;
61 var defaultText = breakpoint ? Common.UIString('Paused on breakpoint') : C ommon.UIString('Debugger paused'); 64 var defaultText = breakpoint ? Common.UIString('Paused on breakpoint') : C ommon.UIString('Debugger paused');
62 messageWrapper = buildWrapper(defaultText); 65 messageWrapper = buildWrapper(defaultText);
63 } else { 66 } else {
64 console.warn( 67 console.warn(
65 'ScriptsPanel paused, but callFrames.length is zero.'); // TODO remov e this once we understand this case better 68 'ScriptsPanel paused, but callFrames.length is zero.'); // TODO remov e this once we understand this case better
66 } 69 }
67 70
68 var errorLike = details.reason === SDK.DebuggerModel.BreakReason.Exception | |
69 details.reason === SDK.DebuggerModel.BreakReason.PromiseRejection ||
70 details.reason === SDK.DebuggerModel.BreakReason.Assert || details.reaso n === SDK.DebuggerModel.BreakReason.OOM;
71 status.classList.toggle('error-reason', errorLike); 71 status.classList.toggle('error-reason', errorLike);
72 if (messageWrapper) 72 if (messageWrapper)
73 status.appendChild(messageWrapper); 73 status.appendChild(messageWrapper);
74 74
75 /** 75 /**
76 * @param {string} mainText 76 * @param {string} mainText
77 * @param {string=} subText 77 * @param {string=} subText
78 * @param {string=} title 78 * @param {string=} title
79 * @return {!Element} 79 * @return {!Element}
80 */ 80 */
81 function buildWrapper(mainText, subText, title) { 81 function buildWrapper(mainText, subText, title) {
82 var messageWrapper = createElement('span'); 82 var messageWrapper = createElement('span');
83 var mainElement = messageWrapper.createChild('div', 'status-main'); 83 var mainElement = messageWrapper.createChild('div', 'status-main');
84 mainElement.appendChild(UI.Icon.create('smallicon-info', 'status-icon')); 84 var icon = UI.Icon.create(errorLike ? 'smallicon-error' : 'smallicon-info' , 'status-icon');
85 mainElement.appendChild(icon);
85 mainElement.appendChild(createTextNode(mainText)); 86 mainElement.appendChild(createTextNode(mainText));
86 if (subText) { 87 if (subText) {
87 var subElement = messageWrapper.createChild('div', 'status-sub monospace '); 88 var subElement = messageWrapper.createChild('div', 'status-sub monospace ');
88 subElement.textContent = subText; 89 subElement.textContent = subText;
89 } 90 }
90 if (title) 91 var tooltip = title || subText;
91 messageWrapper.title = title; 92 if (tooltip)
93 messageWrapper.title = tooltip;
92 return messageWrapper; 94 return messageWrapper;
93 } 95 }
94 } 96 }
95 }; 97 };
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698