Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 275008: [Mac] Log some NSException info with crash dumps. (Closed)

Created:
11 years, 2 months ago by Scott Hess - ex-Googler
Modified:
9 years, 6 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews_googlegroups.com, pink (ping after 24hrs)
Visibility:
Public.

Description

[Mac] Log some NSException info with crash dumps. Adds two breakpad keys. "firstexception" will store the name and reason for the first NSException caught by the event loop. "lastexception" will store the same for the last one seen before crashing. http://crbug.com/24462 TEST=Hard to test without known exceptions to handle. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29349

Patch Set 1 #

Total comments: 2

Patch Set 2 : tree's been closed, double-checking for merge failures. #

Patch Set 3 : obviously better to have merged this way. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M chrome/browser/chrome_application_mac.mm View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Scott Hess - ex-Googler
11 years, 2 months ago (2009-10-13 20:25:49 UTC) #1
John Grabowski
LGTM Please also follow-up using ideas from Neal; e.g. BreakpadGenerateAndSendReport() Perhaps add DCHECK in here ...
11 years, 2 months ago (2009-10-14 18:16:52 UTC) #2
Scott Hess - ex-Googler
11 years, 2 months ago (2009-10-16 17:42:37 UTC) #3
jrg also wrote:
> Please also follow-up using ideas from Neal; e.g.
> BreakpadGenerateAndSendReport() 
> 
> Perhaps add DCHECK in here for developer builds to be more... illustrative?

Am working on those.  Deferring the DCHECK because it doesn't have a push
deadline associated with it.  Still experimenting with forcing a report.

http://codereview.chromium.org/275008/diff/1/2
File chrome/browser/chrome_application_mac.mm (right):

http://codereview.chromium.org/275008/diff/1/2#newcode156
Line 156: NSString* value = [NSString stringWithFormat:@"%@ reason %@",
On 2009/10/14 18:16:52, John Grabowski wrote:
> Can we find a way to do this that doesn't allocate memory?

I think we should be conservative and push what we have.  If we find that it's
excessive, we can always back it down to just -reason or something, but getting
a week of backtraces with firstexception == "NSGenericException" would be
frustrating.

Powered by Google App Engine
This is Rietveld 408576698