Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: pkg/compiler/lib/src/kernel/kernel_visitor.dart

Issue 2750013002: [kernel] Debugging of switch statement (Closed)
Patch Set: Take #2: Update switch case to include list of positions Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/kernel/kernel_visitor.dart
diff --git a/pkg/compiler/lib/src/kernel/kernel_visitor.dart b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
index f8598a179808c5304ea1a9f2ac3366c75edd5a51..5e1147a1555bfda29652b71069dc1aaa940bf66c 100644
--- a/pkg/compiler/lib/src/kernel/kernel_visitor.dart
+++ b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
@@ -1022,10 +1022,15 @@ class KernelVisitor extends Object
assert(labelOrCase.asLabel() != null);
}
}
+ List<int> expressionsOffsets = <int>[];
Kevin Millikin (Google) 2017/03/20 12:29:47 Do this in the loop above. expressionsOffsets ==>
jensj 2017/03/21 10:06:19 Done.
+ for (ir.Expression expression in expressions) {
+ expressionsOffsets.add(expression.fileOffset);
+ }
// We ignore the node's statements here, they're generated below in
// [visitSwitchStatement] once we've set up all the jump targets.
return associateNode(
- new ir.SwitchCase(expressions, null, isDefault: node.isDefaultCase),
+ new ir.SwitchCase(expressions, expressionsOffsets, null,
+ isDefault: node.isDefaultCase),
node);
}

Powered by Google App Engine
This is Rietveld 408576698