[kernel] Debugging of switch statement

pkg/kernel/lib/binary/ast_from_binary.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 library kernel.ast_from_binary;
 
 import 'dart:convert';
 import 'dart:typed_data';
 
 import '../ast.dart';
 import '../transformations/flags.dart';
@@ skipping 890 matching lines @@
         return new ForInStatement(variable, iterable, body, isAsync: isAsync);
       case Tag.SwitchStatement:
         var expression = readExpression();
         int count = readUInt();
         List<SwitchCase> cases =
             new List<SwitchCase>.generate(count, (i) => new SwitchCase.empty());
         switchCaseStack.addAll(cases);
         for (int i = 0; i < cases.length; ++i) {
           var caseNode = cases[i];
           _fillTreeNodeList(caseNode.expressions, readExpression, caseNode);
+          caseNode.expressionsOffsets.length = readUInt();

[Kevin Millikin (Google), 2017/03/20 12:29:47]

I'd just change _fillNonTreeNodeList so it didn't have a type parameter of Node
and use that.  You might adjust the name if you thought it was ambiguous.

_fillNonTreeNodeList(caseNode.expressionOffsets, readOffset);

[jensj, 2017/03/21 10:06:19]

I've changed it to not encode the size as well so that won't work anymore.

+          for (int i = 0; i < caseNode.expressionsOffsets.length; ++i) {
+            caseNode.expressionsOffsets[i] = readOffset();
+          }
           caseNode.isDefault = readByte() == 1;
           caseNode.body = readStatement()..parent = caseNode;
         }
         switchCaseStack.length -= count;
         return new SwitchStatement(expression, cases);
       case Tag.ContinueSwitchStatement:
         int index = readUInt();
         return new ContinueSwitchStatement(switchCaseStack[index]);
       case Tag.IfStatement:
         return new IfStatement(
@@ skipping 187 matching lines @@
       ..fileOffset = offset
       ..fileEqualsOffset = fileEqualsOffset;
   }
 
   int readOffset() {
     // Offset is saved as unsigned,
     // but actually ranges from -1 and up (thus the -1)
     return readUInt() - 1;
   }
 }