Listen for new system certificates.

net/cert/cert_database.h

Index: net/cert/cert_database.h
diff --git a/net/cert/cert_database.h b/net/cert/cert_database.h
index c4ead812f2f6e500b5adb230eb92ef323beec012..7791e894a41b2b4ce955f11305e28b0a2d7d2b36 100644
--- a/net/cert/cert_database.h
+++ b/net/cert/cert_database.h
@@ -43,6 +43,9 @@ class NET_EXPORT CertDatabase {
     // Will be called when a certificate's trust is changed.
     virtual void OnCertTrustChanged(const X509Certificate* cert) {}
 
+    // Will be called when the database changed in a non specific manner.
+    virtual void OnDatabaseUpdated() {}

[wtc, 2013/10/16 15:37:34]

Nit: a non specific manner => an unspecified manner?

I suggest naming this method "OnDatabaseChanged" and the notification method
"NotifyObserversOfDatabaseChanged".

[wtc, 2013/10/16 15:39:31]

Please mention why this broad notification is necessary on some platforms, and
you can name Android as an example. Thanks.

[qsr, 2013/10/16 16:02:09]

Done.

+
    protected:
     Observer() {}
 
@@ -78,6 +81,12 @@ class NET_EXPORT CertDatabase {
   void SetMessageLoopForKeychainEvents();
 #endif
 
+#if defined(OS_ANDROID)
+  // On android, the system database is used. When the system notifies the
+  // application that the certificates changed, the observers must be notified.
+  void NotifyObserversOfDatabaseUpdated();

[wtc, 2013/10/16 15:37:34]

Can this method be declared private, along with the other NotifyObserversOfXXX
methods on lines 96-99?

[qsr, 2013/10/16 16:02:09]

 Not really. It needs to be called externally by the java class that gets
notified when the system database change. Do you prefer a level of indirection?
That would still mean a public method that would just call the private one.

[wtc, 2013/10/16 18:33:24]

Not when I asked you that question. As a code reviewer, I was puzzled why the
existing NotifyObserversOfXXX methods can be private, but
NotifyObserversOfDatabaseUpdated can't.

Perhaps you can name the public method something like
"OnAndroidKeyChainChanged", and have it call
NotifyObserversOfCertTrustChanged(NULL).

+#endif
+
  private:
   friend struct DefaultSingletonTraits<CertDatabase>;