components/keyed_service/content/browser_context_dependency_manager.cc - Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/keyed_service/content/browser_context_dependency_manager.cc

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)

Patch Set: Refactor SiteEngagementService tests. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/keyed_service/content/browser_context_dependency_manager.h ('k') | components/keyed_service/content/browser_context_keyed_base_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/keyed_service/content/browser_context_dependency_manager.cc

diff --git a/components/keyed_service/content/browser_context_dependency_manager.cc b/components/keyed_service/content/browser_context_dependency_manager.cc

index 2e441d99e43e4ff5ead2ed8e15342ccb68ecc490..fe134b9649014ae0f4e7a29249d2f0cc84dc1a67 100644

--- a/components/keyed_service/content/browser_context_dependency_manager.cc

+++ b/components/keyed_service/content/browser_context_dependency_manager.cc

@@ -60,17 +60,15 @@ BrowserContextDependencyManager::

return will_create_browser_context_services_callbacks_.Add(callback);

}

-#ifndef NDEBUG

void BrowserContextDependencyManager::AssertBrowserContextWasntDestroyed(

- content::BrowserContext* context) {

+ content::BrowserContext* context) const {

DependencyManager::AssertContextWasntDestroyed(context);

}

-void BrowserContextDependencyManager::MarkBrowserContextLiveForTesting(

+void BrowserContextDependencyManager::MarkBrowserContextLive(

content::BrowserContext* context) {

- DependencyManager::MarkContextLiveForTesting(context);

+ DependencyManager::MarkContextLive(context);

}

-#endif // NDEBUG

// static

BrowserContextDependencyManager*