Restore KeyedServiceFactory diagnostics for context use-after-destroy.

components/keyed_service/core/keyed_service_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/keyed_service/core/keyed_service_factory.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/stl_util.h"
@@ skipping 12 matching lines @@
 
 void KeyedServiceFactory::SetTestingFactory(
     base::SupportsUserData* context,
     TestingFactoryFunction testing_factory) {
   // Destroying the context may cause us to lose data about whether |context|
   // has our preferences registered on it (since the context object itself
   // isn't dead). See if we need to readd it once we've gone through normal
   // destruction.
   bool add_context = ArePreferencesSetOn(context);
 
-#ifndef NDEBUG
   // Ensure that |context| is not marked as stale (e.g., due to it aliasing an
   // instance that was destroyed in an earlier test) in order to avoid accesses
   // to |context| in |BrowserContextShutdown| from causing
   // |AssertBrowserContextWasntDestroyed| to raise an error.
-  MarkContextLiveForTesting(context);
-#endif
+  MarkContextLive(context);
 
   // We have to go through the shutdown and destroy mechanisms because there
   // are unit tests that create a service on a context and then change the
   // testing service mid-test.
   ContextShutdown(context);
   ContextDestroyed(context);
 
   if (add_context)
     MarkPreferencesSetOn(context);
 
@@ skipping 82 matching lines @@
   SetTestingFactory(context, nullptr);
 }
 
 bool KeyedServiceFactory::HasTestingFactory(base::SupportsUserData* context) {
   return testing_factories_.find(context) != testing_factories_.end();
 }
 
 void KeyedServiceFactory::CreateServiceNow(base::SupportsUserData* context) {
   GetServiceForContext(context, true);
 }