Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)
Patch Set: Refactor SiteEngagementService tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_gcm_app_handler.h" 5 #include "chrome/browser/extensions/extension_gcm_app_handler.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 // Create a fake version of ExtensionGCMAppHandler. 273 // Create a fake version of ExtensionGCMAppHandler.
274 gcm_app_handler_.reset(new FakeExtensionGCMAppHandler(profile(), &waiter_)); 274 gcm_app_handler_.reset(new FakeExtensionGCMAppHandler(profile(), &waiter_));
275 } 275 }
276 276
277 void TearDown() override { 277 void TearDown() override {
278 #if defined(OS_CHROMEOS) 278 #if defined(OS_CHROMEOS)
279 test_user_manager_.reset(); 279 test_user_manager_.reset();
280 #endif 280 #endif
281 281
282 waiter_.PumpUILoop(); 282 waiter_.PumpUILoop();
283 gcm_app_handler_->Shutdown();
283 } 284 }
284 285
285 // Returns a barebones test extension. 286 // Returns a barebones test extension.
286 scoped_refptr<Extension> CreateExtension() { 287 scoped_refptr<Extension> CreateExtension() {
287 base::DictionaryValue manifest; 288 base::DictionaryValue manifest;
288 manifest.SetString(manifest_keys::kVersion, "1.0.0.0"); 289 manifest.SetString(manifest_keys::kVersion, "1.0.0.0");
289 manifest.SetString(manifest_keys::kName, kTestExtensionName); 290 manifest.SetString(manifest_keys::kName, kTestExtensionName);
290 base::ListValue* permission_list = new base::ListValue; 291 base::ListValue* permission_list = new base::ListValue;
291 permission_list->AppendString("gcm"); 292 permission_list->AppendString("gcm");
292 manifest.Set(manifest_keys::kPermissions, permission_list); 293 manifest.Set(manifest_keys::kPermissions, permission_list);
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 484
484 // App handler is removed when the extension is updated to the version that 485 // App handler is removed when the extension is updated to the version that
485 // has GCM permission removed. 486 // has GCM permission removed.
486 UpdateExtension(extension.get(), "good2.crx"); 487 UpdateExtension(extension.get(), "good2.crx");
487 waiter()->PumpUILoop(); 488 waiter()->PumpUILoop();
488 EXPECT_TRUE(gcm_app_handler()->app_handler_count_drop_to_zero()); 489 EXPECT_TRUE(gcm_app_handler()->app_handler_count_drop_to_zero());
489 EXPECT_FALSE(HasAppHandlers(extension->id())); 490 EXPECT_FALSE(HasAppHandlers(extension->id()));
490 } 491 }
491 492
492 } // namespace extensions 493 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698