Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Side by Side Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h

Issue 2749823002: Restore KeyedServiceFactory diagnostics for context use-after-destroy. (Closed)
Patch Set: Refactor SiteEngagementService tests. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_SIGNED_IN_DEVICES_SIGNED_IN_DEVICES_MANAGE R_H__ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_SIGNED_IN_DEVICES_SIGNED_IN_DEVICES_MANAGE R_H__
6 #define CHROME_BROWSER_EXTENSIONS_API_SIGNED_IN_DEVICES_SIGNED_IN_DEVICES_MANAGE R_H__ 6 #define CHROME_BROWSER_EXTENSIONS_API_SIGNED_IN_DEVICES_SIGNED_IN_DEVICES_MANAGE R_H__
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 public EventRouter::Observer { 61 public EventRouter::Observer {
62 public: 62 public:
63 // Default constructor used for testing. 63 // Default constructor used for testing.
64 SignedInDevicesManager(); 64 SignedInDevicesManager();
65 explicit SignedInDevicesManager(content::BrowserContext* context); 65 explicit SignedInDevicesManager(content::BrowserContext* context);
66 ~SignedInDevicesManager() override; 66 ~SignedInDevicesManager() override;
67 67
68 // BrowserContextKeyedAPI implementation. 68 // BrowserContextKeyedAPI implementation.
69 static BrowserContextKeyedAPIFactory<SignedInDevicesManager>* 69 static BrowserContextKeyedAPIFactory<SignedInDevicesManager>*
70 GetFactoryInstance(); 70 GetFactoryInstance();
71 void Shutdown() override;
71 72
72 // ExtensionRegistryObserver implementation. 73 // ExtensionRegistryObserver implementation.
73 void OnExtensionUnloaded(content::BrowserContext* browser_context, 74 void OnExtensionUnloaded(content::BrowserContext* browser_context,
74 const Extension* extension, 75 const Extension* extension,
75 UnloadedExtensionInfo::Reason reason) override; 76 UnloadedExtensionInfo::Reason reason) override;
76 77
77 // EventRouter::Observer: 78 // EventRouter::Observer:
78 void OnListenerAdded(const EventListenerInfo& details) override; 79 void OnListenerAdded(const EventListenerInfo& details) override;
79 void OnListenerRemoved(const EventListenerInfo& details) override; 80 void OnListenerRemoved(const EventListenerInfo& details) override;
80 81
(...skipping 16 matching lines...) Expand all
97 extension_registry_observer_; 98 extension_registry_observer_;
98 99
99 FRIEND_TEST_ALL_PREFIXES(SignedInDevicesManager, UpdateListener); 100 FRIEND_TEST_ALL_PREFIXES(SignedInDevicesManager, UpdateListener);
100 101
101 DISALLOW_COPY_AND_ASSIGN(SignedInDevicesManager); 102 DISALLOW_COPY_AND_ASSIGN(SignedInDevicesManager);
102 }; 103 };
103 104
104 } // namespace extensions 105 } // namespace extensions
105 106
106 #endif // CHROME_BROWSER_EXTENSIONS_API_SIGNED_IN_DEVICES_SIGNED_IN_DEVICES_MAN AGER_H__ 107 #endif // CHROME_BROWSER_EXTENSIONS_API_SIGNED_IN_DEVICES_SIGNED_IN_DEVICES_MAN AGER_H__
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698