Restore KeyedServiceFactory diagnostics for context use-after-destroy.

components/keyed_service/content/refcounted_browser_context_keyed_service_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h"
 
 #include "base/logging.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/keyed_service/core/refcounted_keyed_service.h"
 #include "content/public/browser/browser_context.h"
@@ skipping 31 matching lines @@
 scoped_refptr<RefcountedKeyedService>
 RefcountedBrowserContextKeyedServiceFactory::GetServiceForBrowserContext(
     content::BrowserContext* context,
     bool create) {
   return RefcountedKeyedServiceFactory::GetServiceForContext(context, create);
 }
 
 content::BrowserContext*
 RefcountedBrowserContextKeyedServiceFactory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
+  // TODO(crbug.com/701326): This DCHECK should be moved to GetContextToUse().
   DCHECK(CalledOnValidThread());
 
-#ifndef NDEBUG
-  AssertContextWasntDestroyed(context);

[Paweł Hajdan Jr., 2017/03/21 13:03:24]

Why do we remove this assertion?

-#endif
-
   // Safe default for Incognito mode: no service.
   if (context->IsOffTheRecord())
     return nullptr;
 
   return context;
 }
 
 bool RefcountedBrowserContextKeyedServiceFactory::
     ServiceIsCreatedWithBrowserContext() const {
   return KeyedServiceBaseFactory::ServiceIsCreatedWithContext();
@@ skipping 22 matching lines @@
 }
 
 bool RefcountedBrowserContextKeyedServiceFactory::IsOffTheRecord(
     base::SupportsUserData* context) const {
   return static_cast<content::BrowserContext*>(context)->IsOffTheRecord();
 }
 
 base::SupportsUserData*
 RefcountedBrowserContextKeyedServiceFactory::GetContextToUse(
     base::SupportsUserData* context) const {
+  AssertContextWasntDestroyed(context);
   return GetBrowserContextToUse(static_cast<content::BrowserContext*>(context));
 }
 
 bool RefcountedBrowserContextKeyedServiceFactory::ServiceIsCreatedWithContext()
     const {
   return ServiceIsCreatedWithBrowserContext();
 }
 
 void RefcountedBrowserContextKeyedServiceFactory::ContextShutdown(
     base::SupportsUserData* context) {
   BrowserContextShutdown(static_cast<content::BrowserContext*>(context));
 }
 
 void RefcountedBrowserContextKeyedServiceFactory::ContextDestroyed(
     base::SupportsUserData* context) {
   BrowserContextDestroyed(static_cast<content::BrowserContext*>(context));
 }
 
 void RefcountedBrowserContextKeyedServiceFactory::RegisterPrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   RegisterProfilePrefs(registry);
 }