Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 274973002: Add Help wrench submenu (Closed)

Created:
6 years, 7 months ago by stevenjb
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Add Help wrench submenu This creates a 'Help' submenu with 'Chrome Help Center' and 'Report an Issue...'. This menu will be consistent across platforms. BUG=371094 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274365

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Use 'Get Help' on Chrome OS #

Patch Set 5 : Rebase #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -36 lines) Patch
M chrome/app/chrome_command_ids.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 4 5 6 chunks +48 lines, -32 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
stevenjb
6 years, 7 months ago (2014-05-09 01:01:49 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-09 14:05:36 UTC) #2
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 7 months ago (2014-05-09 16:42:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/274973002/40001
6 years, 7 months ago (2014-05-09 16:48:13 UTC) #4
stevenjb
The CQ bit was unchecked by stevenjb@chromium.org
6 years, 7 months ago (2014-05-09 17:17:45 UTC) #5
stevenjb
We decided to go ahead with this as-is after all.
6 years, 6 months ago (2014-06-02 19:53:37 UTC) #6
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 6 months ago (2014-06-02 19:53:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/274973002/100001
6 years, 6 months ago (2014-06-02 19:55:41 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 23:22:00 UTC) #9
Message was sent while issue was closed.
Change committed as 274365

Powered by Google App Engine
This is Rietveld 408576698