ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h - Issue 2749703003: Adding mediator for Sign-in promo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h

Issue 2749703003: Adding mediator for Sign-in promo (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/ui/authentication/signin_promo_view.mm ('K') | « ios/chrome/browser/ui/authentication/signin_promo_view.mm ('k') | ios/chrome/browser/ui/authentication/signin_promo_view_mediator.mm » ('j') | ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_AUTHENTICATION_SIGNIN_PROMO_VIEW_MEDIATOR_H_

	6 #define IOS_CHROME_BROWSER_UI_AUTHENTICATION_SIGNIN_PROMO_VIEW_MEDIATOR_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 #import "ios/chrome/browser/ui/authentication/signin_promo_view.h"

	11

	12 // Class that configures a SigninPromoView instance. This class is a simple

	13 // implementation that only stores data.

	14 // Create a subclass that monitors profile notification.

	15 @interface SigninPromoViewMediator : NSObject<SigninPromoViewConfigurator>

	16

	17 @property(nonatomic, copy) NSString* userFullName;
	msarda 2017/03/28 08:12:52 I think the following comment from a previous patc I think the following comment from a previous patch was missed: msarda's comment: "I do not understand the interest of having a SigninPromoViewMediator and a ProfileSigninPromoViewMediator in folder ios/chrome/browser/ui/authentication/ - there should be only one here and it must use the ChromeIdentity objects. If there is a need for a specialized SigninPromoViewMediator in the cell catalog, then this class should be moved in that folder and only used there (I want us to avoid subclassing for the mediator as this adds unnecessary complexity that we'll have to maintain in the future)." lpromero's response: "Agreed. The cell catalog should not add complexity." jlebel 2017/03/28 12:27:21 Acknowledged. Will be done in crrev.com/2750403003 Show quoted text On 2017/03/28 08:12:52, msarda wrote: > I think the following comment from a previous patch was missed: > msarda's comment: > "I do not understand the interest of having a SigninPromoViewMediator and a > ProfileSigninPromoViewMediator in folder ios/chrome/browser/ui/authentication/ - > there should be only one here and it must use the ChromeIdentity objects. > > If there is a need for a specialized SigninPromoViewMediator in the cell > catalog, then this class should be moved in that folder and only used there (I > want us to avoid subclassing for the mediator as this adds unnecessary > complexity that we'll have to maintain in the future)." > > lpromero's response: > "Agreed. The cell catalog should not add complexity." Acknowledged. Will be done in crrev.com/2750403003
	18 @property(nonatomic, copy) NSString* userEmail;

	19 @property(nonatomic, copy) UIImage* userImage;

	20

	21 @end

	22

	23 #endif // IOS_CHROME_BROWSER_UI_AUTHENTICATION_SIGNIN_PROMO_VIEW_MEDIATOR_H_

OLD	NEW