Adding mediator for Sign-in promo

ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.h"
 
 #import <UIKit/UIKit.h>
 
 #import "base/mac/foundation_util.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/grit/components_scaled_resources.h"
 #import "ios/chrome/browser/payments/cells/autofill_profile_item.h"
 #import "ios/chrome/browser/payments/cells/payments_text_item.h"
 #import "ios/chrome/browser/payments/cells/price_item.h"
 #import "ios/chrome/browser/ui/authentication/account_control_item.h"
+#import "ios/chrome/browser/ui/authentication/signin_promo_item.h"
+#import "ios/chrome/browser/ui/authentication/signin_promo_view_mediator.h"

[lpromero, 2017/03/22 16:18:49]

You shouldn't need the mediator here. You need to create an object responding to
the SigninPromoViewConfigurator protocol that returns sample data.

[jlebel, 2017/03/24 20:59:10]

I need to alloc a SigninPromoViewMediator instance. How would I do that?

[lpromero, 2017/03/27 13:14:46]

Can't you just use here:

@interface MyConfigurator : NSObject<SigninPromoViewConfigurator>
@end

that would just implement the protocol? No need to loop the mediator in at all.

 #import "ios/chrome/browser/ui/autofill/cells/cvc_item.h"
 #import "ios/chrome/browser/ui/autofill/cells/status_item.h"
 #import "ios/chrome/browser/ui/autofill/cells/storage_switch_item.h"
 #import "ios/chrome/browser/ui/collection_view/cells/MDCCollectionViewCell+Chrome.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_account_item.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_detail_item.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_switch_item.h"
 #import "ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h"
 #import "ios/chrome/browser/ui/collection_view/collection_view_model.h"
 #import "ios/chrome/browser/ui/content_suggestions/content_suggestions_article_item.h"
 #import "ios/chrome/browser/ui/content_suggestions/content_suggestions_footer_item.h"
 #import "ios/chrome/browser/ui/icons/chrome_icon.h"
 #import "ios/chrome/browser/ui/settings/cells/account_signin_item.h"
 #import "ios/chrome/browser/ui/settings/cells/autofill_data_item.h"
 #import "ios/chrome/browser/ui/settings/cells/autofill_edit_item.h"
 #import "ios/chrome/browser/ui/settings/cells/native_app_item.h"
-#import "ios/chrome/browser/ui/settings/cells/signin_promo_item.h"
 #import "ios/chrome/browser/ui/settings/cells/sync_switch_item.h"
 #import "ios/chrome/browser/ui/settings/cells/text_and_error_item.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #import "ios/public/provider/chrome/browser/chrome_browser_provider.h"
 #import "ios/public/provider/chrome/browser/signin/signin_resources_provider.h"
 #import "ios/third_party/material_components_ios/src/components/CollectionCells/src/MaterialCollectionCells.h"
 #import "ios/third_party/material_components_ios/src/components/Palettes/src/MaterialPalettes.h"
 #import "ios/third_party/material_roboto_font_loader_ios/src/src/MaterialRobotoFontLoader.h"
 
 namespace {
@@ skipping 21 matching lines @@
   ItemTypeDetailLeftLong,
   ItemTypeDetailRightLong,
   ItemTypeDetailBothLong,
   ItemTypeSwitchBasic,
   ItemTypeSwitchDynamicHeight,
   ItemTypeSwitchSync,
   ItemTypeHeader,
   ItemTypeAccountDetail,
   ItemTypeAccountCheckMark,
   ItemTypeAccountSignIn,
-  ItemTypeSigninPromo,
+  ItemTypeColdStartSigninPromo,
+  ItemTypeWarmStartSigninPromo,

[lpromero, 2017/03/24 10:36:20]

BTW, what happened to the hot version?

[jlebel, 2017/03/24 20:59:10]

It will be done by the current code.

   ItemTypeApp,
   ItemTypePaymentsSingleLine,
   ItemTypePaymentsDynamicHeight,
   ItemTypeAutofillDynamicHeight,
   ItemTypeAutofillCVC,
   ItemTypeAutofillStatus,
   ItemTypeAutofillStorageSwitch,
   ItemTypeAccountControlDynamicHeight,
   ItemTypeFooter,
   ItemTypeContentSuggestions,
@@ skipping 202 matching lines @@
       toSectionWithIdentifier:SectionIdentifierPayments];
 
   // Account cells.
   [model addSectionWithIdentifier:SectionIdentifierAccountCell];
   [model addItem:[self accountItemDetailWithError]
       toSectionWithIdentifier:SectionIdentifierAccountCell];
   [model addItem:[self accountItemCheckMark]
       toSectionWithIdentifier:SectionIdentifierAccountCell];
   [model addItem:[self accountSignInItem]
       toSectionWithIdentifier:SectionIdentifierAccountCell];
-  [model addItem:[self signinPromoItem]
+  [model addItem:[self coldStartSigninPromoItem]
+      toSectionWithIdentifier:SectionIdentifierAccountCell];
+  [model addItem:[self warmStartSigninPromoItem]
       toSectionWithIdentifier:SectionIdentifierAccountCell];
 
   // Account control cells.
   [model addSectionWithIdentifier:SectionIdentifierAccountControlCell];
   [model addItem:[self accountControlItem]
       toSectionWithIdentifier:SectionIdentifierAccountControlCell];
   [model addItem:[self accountControlItemWithExtraLongText]
       toSectionWithIdentifier:SectionIdentifierAccountControlCell];
 
   // Content Suggestions cells.
@@ skipping 49 matching lines @@
     case ItemTypeFooter:
     case ItemTypeSwitchDynamicHeight:
     case ItemTypeSwitchSync:
     case ItemTypeAccountControlDynamicHeight:
     case ItemTypeTextError:
     case ItemTypeAutofillCVC:
     case ItemTypeAutofillStatus:
     case ItemTypeAutofillStorageSwitch:
     case ItemTypePaymentsDynamicHeight:
     case ItemTypeAutofillDynamicHeight:
-    case ItemTypeSigninPromo:
+    case ItemTypeColdStartSigninPromo:
+    case ItemTypeWarmStartSigninPromo:
       return [MDCCollectionViewCell
           cr_preferredHeightForWidth:CGRectGetWidth(collectionView.bounds)
                              forItem:item];
     case ItemTypeApp:
       return MDCCellDefaultOneLineWithAvatarHeight;
     case ItemTypeAccountDetail:
       return MDCCellDefaultTwoLineHeight;
     case ItemTypeAccountCheckMark:
       return MDCCellDefaultTwoLineHeight;
     case ItemTypeAccountSignIn:
@@ skipping 33 matching lines @@
 
 - (BOOL)collectionView:(nonnull UICollectionView*)collectionView
     hidesInkViewAtIndexPath:(nonnull NSIndexPath*)indexPath {
   NSInteger sectionIdentifier =
       [self.collectionViewModel sectionIdentifierForSection:indexPath.section];
   if (sectionIdentifier == SectionIdentifierFooters)
     return YES;
   CollectionViewItem* item =
       [self.collectionViewModel itemAtIndexPath:indexPath];
   switch (item.type) {
+    case ItemTypeApp:
+    case ItemTypeAutofillStorageSwitch:
+    case ItemTypeColdStartSigninPromo:
     case ItemTypeSwitchBasic:
     case ItemTypeSwitchDynamicHeight:
-    case ItemTypeApp:
-    case ItemTypeAutofillStorageSwitch:
     case ItemTypeSwitchSync:
-    case ItemTypeSigninPromo:
+    case ItemTypeWarmStartSigninPromo:
       return YES;
     default:
       return NO;
   }
 }
 
 #pragma mark Item models
 
 - (CollectionViewItem*)accountItemDetailWithError {
   CollectionViewAccountItem* accountItemDetail =
@@ skipping 28 matching lines @@
   AccountSignInItem* accountSignInItem = [[[AccountSignInItem alloc]
       initWithType:ItemTypeAccountSignIn] autorelease];
   accountSignInItem.image =
       CircularImageFromImage(ios::GetChromeBrowserProvider()
                                  ->GetSigninResourcesProvider()
                                  ->GetDefaultAvatar(),
                              kHorizontalImageFixedSize);
   return accountSignInItem;
 }
 
-- (CollectionViewItem*)signinPromoItem {
-  SigninPromoItem* signinPromoItem =
-      [[[SigninPromoItem alloc] initWithType:ItemTypeSigninPromo] autorelease];
-  signinPromoItem.profileName = @"Jane";
-  signinPromoItem.profileEmail = @"jane@example.com";
-  signinPromoItem.profileImage =
-      CircularImageFromImage(ios::GetChromeBrowserProvider()
-                                 ->GetSigninResourcesProvider()
-                                 ->GetDefaultAvatar(),
-                             kHorizontalImageFixedSize);
+- (CollectionViewItem*)coldStartSigninPromoItem {
+  SigninPromoViewMediator* signinPromoViewMediator =
+      [[SigninPromoViewMediator alloc] init];
+  SigninPromoItem* signinPromoItem = [[[SigninPromoItem alloc]
+                     initWithType:ItemTypeWarmStartSigninPromo
+      signinPromoViewConfigurator:signinPromoViewMediator] autorelease];
   return signinPromoItem;
 }
 
+- (CollectionViewItem*)warmStartSigninPromoItem {
+  SigninPromoViewMediator* signinPromoViewMediator =
+      [[SigninPromoViewMediator alloc] init];
+  signinPromoViewMediator.userFullName = @"John Doe";
+  signinPromoViewMediator.userEmail = @"johndoe@example.com";
+  SigninPromoItem* signinPromoItem = [[[SigninPromoItem alloc]
+                     initWithType:ItemTypeColdStartSigninPromo
+      signinPromoViewConfigurator:signinPromoViewMediator] autorelease];
+  return signinPromoItem;
+}
+
 - (CollectionViewItem*)accountControlItem {
   AccountControlItem* item = [[[AccountControlItem alloc]
       initWithType:ItemTypeAccountControlDynamicHeight] autorelease];
   item.image = [UIImage imageNamed:@"settings_sync"];
   item.text = @"Account Sync Settings";
   item.detailText = @"Detail text";
   item.accessoryType = MDCCollectionViewCellAccessoryDisclosureIndicator;
   return item;
 }
 
@@ skipping 197 matching lines @@
 - (ContentSuggestionsFooterItem*)contentSuggestionsFooterItem {
   ContentSuggestionsFooterItem* footerItem =
       [[ContentSuggestionsFooterItem alloc]
           initWithType:ItemTypeContentSuggestions
                  title:@"Footer title"
                  block:nil];
   return footerItem;
 }
 
 @end