Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

Issue 2749703002: Refactor ImageFrame::setSizeAndColorSpace() (Closed)
Patch Set: Forgot to update the call sites Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
diff --git a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
index 641012756bc353bc3cce7b30e28e29cc6acd17a1..f5529c378ab50d7e855e57c41dfeff60282ccce4 100644
--- a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
+++ b/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
@@ -937,10 +937,12 @@ bool JPEGImageDecoder::outputScanlines() {
DCHECK_EQ(info->output_height,
static_cast<JDIMENSION>(m_decodedSize.height()));
- if (!buffer.setSizeAndColorSpace(info->output_width, info->output_height,
+ if (!buffer.allocateBackingStore(info->output_width, info->output_height,
colorSpaceForSkImages()))
return setFailed();
+ buffer.zeroFillPixelData();
+
// The buffer is transparent outside the decoded area while the image is
// loading. The image will be marked fully opaque in complete().
buffer.setStatus(ImageFrame::FramePartial);

Powered by Google App Engine
This is Rietveld 408576698