Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp

Issue 2749703002: Refactor ImageFrame::setSizeAndColorSpace() (Closed)
Patch Set: Fix alloc returned value flipped Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
diff --git a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
index 641012756bc353bc3cce7b30e28e29cc6acd17a1..3e8750ebbecfd1f115a263205f99f395cb9586b4 100644
--- a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
+++ b/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
@@ -941,6 +941,8 @@ bool JPEGImageDecoder::outputScanlines() {
colorSpaceForSkImages()))
return setFailed();
+ buffer.zeroFillPixelData();
Noel Gordon 2017/03/14 06:30:41 Here and elsewhere you made this change, consider
Peter Kasting 2017/03/14 07:34:40 Hmm. It worries me that zeroFillPixelData() sets
cblume 2017/03/14 17:30:50 I think both of you had really good points. I woul
+
// The buffer is transparent outside the decoded area while the image is
// loading. The image will be marked fully opaque in complete().
buffer.setStatus(ImageFrame::FramePartial);

Powered by Google App Engine
This is Rietveld 408576698