third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h - Issue 2749703002: Refactor ImageFrame::setSizeAndColorSpace()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

Issue 2749703002: Refactor ImageFrame::setSizeAndColorSpace() (Closed)

Patch Set: Call setHasAlpha(true); from within zeroFillPixelData() Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h b/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

index a99bb4680551e26e4936133969e7c44900430368..c4ef7da4e722d494d33e86a8fc2d74c8972b06da 100644

--- a/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

+++ b/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

@@ -111,8 +111,9 @@ class MockImageDecoder : public ImageDecoder {

}

void initializeNewFrame(size_t index) override {

- m_frameBufferCache[index].setSizeAndColorSpace(

- size().width(), size().height(), colorSpaceForSkImages());

+ if (m_frameBufferCache[index].allocatePixelData(

+ size().width(), size().height(), colorSpaceForSkImages()))

+ m_frameBufferCache[index].zeroFillPixelData();

m_frameBufferCache[index].setHasAlpha(false);

}