Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

Issue 2749703002: Refactor ImageFrame::setSizeAndColorSpace() (Closed)
Patch Set: Moving to another CR the separation of zeroing pixel data from setting alpha Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 void decodeSize() override {} 104 void decodeSize() override {}
105 105
106 size_t decodeFrameCount() override { return m_client->frameCount(); } 106 size_t decodeFrameCount() override { return m_client->frameCount(); }
107 107
108 void decode(size_t index) override { 108 void decode(size_t index) override {
109 m_client->decodeRequested(); 109 m_client->decodeRequested();
110 m_frameBufferCache[index].setStatus(m_client->status()); 110 m_frameBufferCache[index].setStatus(m_client->status());
111 } 111 }
112 112
113 void initializeNewFrame(size_t index) override { 113 void initializeNewFrame(size_t index) override {
114 m_frameBufferCache[index].setSizeAndColorSpace( 114 if (m_frameBufferCache[index].allocatePixelData(
115 size().width(), size().height(), colorSpaceForSkImages()); 115 size().width(), size().height(), colorSpaceForSkImages()))
116 m_frameBufferCache[index].zeroFillPixelData();
116 m_frameBufferCache[index].setHasAlpha(false); 117 m_frameBufferCache[index].setHasAlpha(false);
117 } 118 }
118 119
119 MockImageDecoderClient* m_client; 120 MockImageDecoderClient* m_client;
120 }; 121 };
121 122
122 class MockImageDecoderFactory : public ImageDecoderFactory { 123 class MockImageDecoderFactory : public ImageDecoderFactory {
123 public: 124 public:
124 static std::unique_ptr<MockImageDecoderFactory> create( 125 static std::unique_ptr<MockImageDecoderFactory> create(
125 MockImageDecoderClient* client, 126 MockImageDecoderClient* client,
(...skipping 20 matching lines...) Expand all
146 const IntSize& decodedSize) 147 const IntSize& decodedSize)
147 : m_client(client), m_decodedSize(decodedSize) {} 148 : m_client(client), m_decodedSize(decodedSize) {}
148 149
149 MockImageDecoderClient* m_client; 150 MockImageDecoderClient* m_client;
150 IntSize m_decodedSize; 151 IntSize m_decodedSize;
151 }; 152 };
152 153
153 } // namespace blink 154 } // namespace blink
154 155
155 #endif // MockImageDecoder_h 156 #endif // MockImageDecoder_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698