Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2749673003: Revert of Collect type profile for DevTools. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecodes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index 2fe37921d1d3b80129a7ba716cf714e52fd50f7d..a4e9e1a5e8ed38920be57924c5d8f3d187da2719 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -2214,34 +2214,18 @@
LhsKind assign_type = Property::GetAssignType(property);
// Evaluate LHS expression.
- Register lhs_name;
- if (expr->HasTypeProfileSlot()) {
- lhs_name = register_allocator()->NewRegister();
- }
-
switch (assign_type) {
case VARIABLE:
- if (expr->HasTypeProfileSlot()) {
- builder()
- ->LoadLiteral(expr->target()->AsVariableProxy()->var()->raw_name())
- .StoreAccumulatorInRegister(lhs_name);
- }
// Nothing to do to evaluate variable assignment LHS.
break;
case NAMED_PROPERTY: {
object = VisitForRegisterValue(property->obj());
name = property->key()->AsLiteral()->AsRawPropertyName();
- if (expr->HasTypeProfileSlot()) {
- builder()->LoadLiteral(name).StoreAccumulatorInRegister(lhs_name);
- }
break;
}
case KEYED_PROPERTY: {
object = VisitForRegisterValue(property->obj());
key = VisitForRegisterValue(property->key());
- if (expr->HasTypeProfileSlot()) {
- builder()->StoreAccumulatorInRegister(lhs_name);
- }
break;
}
case NAMED_SUPER_PROPERTY: {
@@ -2254,9 +2238,6 @@
builder()
->LoadLiteral(property->key()->AsLiteral()->AsRawPropertyName())
.StoreAccumulatorInRegister(super_property_args[2]);
- if (expr->HasTypeProfileSlot()) {
- builder()->StoreAccumulatorInRegister(lhs_name);
- }
break;
}
case KEYED_SUPER_PROPERTY: {
@@ -2267,10 +2248,6 @@
VisitForRegisterValue(super_property->home_object(),
super_property_args[1]);
VisitForRegisterValue(property->key(), super_property_args[2]);
- if (expr->HasTypeProfileSlot()) {
- builder()->StoreAccumulatorInRegister(lhs_name);
- }
-
break;
}
}
@@ -2358,14 +2335,6 @@
.CallRuntime(StoreKeyedToSuperRuntimeId(), super_property_args);
break;
}
- }
-
- // Value is in accumulator.
- if (expr->HasTypeProfileSlot()) {
- FeedbackSlot collect_type_feedback_slot = expr->TypeProfileSlot();
-
- builder()->CollectTypeProfile(lhs_name,
- feedback_index(collect_type_feedback_slot));
}
}
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecodes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698