Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: src/compiler.cc

Issue 2749673003: Revert of Collect type profile for DevTools. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/ast-numbering.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler.h" 5 #include "src/compiler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <memory> 8 #include <memory>
9 9
10 #include "src/asmjs/asm-js.h" 10 #include "src/asmjs/asm-js.h"
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 } 471 }
472 if (literal->flags() & AstProperties::kMustUseIgnitionTurbo) { 472 if (literal->flags() & AstProperties::kMustUseIgnitionTurbo) {
473 shared_info->set_must_use_ignition_turbo(true); 473 shared_info->set_must_use_ignition_turbo(true);
474 } 474 }
475 } 475 }
476 476
477 bool Renumber(ParseInfo* parse_info, 477 bool Renumber(ParseInfo* parse_info,
478 Compiler::EagerInnerFunctionLiterals* eager_literals) { 478 Compiler::EagerInnerFunctionLiterals* eager_literals) {
479 RuntimeCallTimerScope runtimeTimer(parse_info->isolate(), 479 RuntimeCallTimerScope runtimeTimer(parse_info->isolate(),
480 &RuntimeCallStats::CompileRenumber); 480 &RuntimeCallStats::CompileRenumber);
481
482 // CollectTypeProfile uses its own feedback slots. If we have existing
483 // FeedbackMetadata, we can only collect type profile, if the feedback vector
484 // has the appropriate slots.
485 bool collect_type_profile;
486 if (parse_info->shared_info().is_null() ||
487 parse_info->shared_info()->feedback_metadata()->length() == 0) {
488 collect_type_profile = FLAG_type_profile;
489 } else {
490 collect_type_profile =
491 parse_info->shared_info()->feedback_metadata()->HasTypeProfileSlot();
492 }
493
494 if (!AstNumbering::Renumber( 481 if (!AstNumbering::Renumber(
495 parse_info->isolate()->stack_guard()->real_climit(), 482 parse_info->isolate()->stack_guard()->real_climit(),
496 parse_info->zone(), parse_info->literal(), eager_literals, 483 parse_info->zone(), parse_info->literal(), eager_literals)) {
497 collect_type_profile)) {
498 return false; 484 return false;
499 } 485 }
500 if (!parse_info->shared_info().is_null()) { 486 if (!parse_info->shared_info().is_null()) {
501 SetSharedFunctionFlagsFromLiteral(parse_info->literal(), 487 SetSharedFunctionFlagsFromLiteral(parse_info->literal(),
502 parse_info->shared_info()); 488 parse_info->shared_info());
503 } 489 }
504 return true; 490 return true;
505 } 491 }
506 492
507 bool GenerateUnoptimizedCode(CompilationInfo* info) { 493 bool GenerateUnoptimizedCode(CompilationInfo* info) {
(...skipping 1444 matching lines...) Expand 10 before | Expand all | Expand 10 after
1952 } 1938 }
1953 1939
1954 if (shared->is_compiled()) { 1940 if (shared->is_compiled()) {
1955 // TODO(mvstanton): pass pretenure flag to EnsureLiterals. 1941 // TODO(mvstanton): pass pretenure flag to EnsureLiterals.
1956 JSFunction::EnsureLiterals(function); 1942 JSFunction::EnsureLiterals(function);
1957 } 1943 }
1958 } 1944 }
1959 1945
1960 } // namespace internal 1946 } // namespace internal
1961 } // namespace v8 1947 } // namespace v8
OLDNEW
« no previous file with comments | « src/ast/ast-numbering.cc ('k') | src/compiler/bytecode-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698