Prototype HTMLVideoElement properties for WebGL texImage2D

media/blink/webmediaplayer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <limits>
 #include <string>
@@ skipping 684 matching lines @@
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
   base::Optional<MediaTrack::Id> selected_video_track_id;
   if (selectedTrackId && !video_track_disabled_)
     selected_video_track_id = MediaTrack::Id(selectedTrackId->utf8().data());
   MEDIA_LOG(INFO, media_log_) << "Selected video track: ["
                               << selected_video_track_id.value_or("") << "]";
   pipeline_controller_.OnSelectedVideoTrackChanged(selected_video_track_id);
 }
 
+bool WebMediaPlayerImpl::getCurrentFrameInfo(unsigned* width,
+                                             unsigned* height,
+                                             double* timestamp) {
+  scoped_refptr<VideoFrame> video_frame = GetCurrentFrameFromCompositor();

[Ken Russell (switch to Gerrit), 2017/03/15 04:41:50]

As Dale points out, this isn't guaranteed to be correct because the current
frame may have changed since the point where the HTMLVideoElement called into
the WebMediaPlayer.

Instead, I suggest adding a helper method which records the width, height and
timestamp from a passed VideoFrame along the code paths for the three entry
points -- copyVideoTextureToPlatformTexture, paint, and texImageImpl -- and then
have getCurrentFrameInfo return those cached values.

+  *width = video_frame->natural_size().width();
+  *height = video_frame->natural_size().height();
+  *timestamp = video_frame->timestamp().InSecondsF();
+  return true;
+}
+
 blink::WebSize WebMediaPlayerImpl::naturalSize() const {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
   return blink::WebSize(pipeline_metadata_.natural_size);
 }
 
 bool WebMediaPlayerImpl::paused() const {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
 #if defined(OS_ANDROID)  // WMPI_CAST
@@ skipping 1605 matching lines @@
 
 void WebMediaPlayerImpl::RecordUnderflowDuration(base::TimeDelta duration) {
   DCHECK(data_source_ || chunk_demuxer_);
   if (data_source_)
     UMA_HISTOGRAM_TIMES("Media.UnderflowDuration", duration);
   else
     UMA_HISTOGRAM_TIMES("Media.UnderflowDuration.MSE", duration);
 }
 
 }  // namespace media