Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart

Issue 2749643002: Create DeclaredSimpleIdentifier when parse a declaration with Fasta. (Closed)
Patch Set: Fixes for review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
index 857220999f4a2342aa7fd6cc437b38556504afc3..55b4fc8c25fc067cd00873dd4ef4deb75c49c27c 100644
--- a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
+++ b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
@@ -182,7 +182,8 @@ class AstBuilder extends ScopeListener {
return;
}
- SimpleIdentifier identifier = ast.simpleIdentifier(analyzerToken);
+ SimpleIdentifier identifier = ast.simpleIdentifier(analyzerToken,
+ isDeclaration: context.inDeclaration);
if (context.inLibraryOrPartOfDeclaration) {
if (!context.isContinuation) {
push([identifier]);
@@ -1313,7 +1314,7 @@ class AstBuilder extends ScopeListener {
toAnalyzerToken(modifiers?.externalKeyword),
toAnalyzerToken(modifiers?.finalConstOrVarKeyword),
null, // TODO(paulberry): factoryKeyword
- returnType,
+ ast.simpleIdentifier(returnType.token),
period,
name,
parameters,
« no previous file with comments | « pkg/analyzer/test/generated/parser_test.dart ('k') | pkg/front_end/lib/src/fasta/parser/identifier_context.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698