Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: telemetry/telemetry/testing/fakes/__init__.py

Issue 2749633004: Track telemetry benchmark cycle time (Closed)
Patch Set: Remove unused import Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/testing/fakes/__init__.py
diff --git a/telemetry/telemetry/testing/fakes/__init__.py b/telemetry/telemetry/testing/fakes/__init__.py
index 71d1d2afb6ba99a207af3ffd1f13c479295b8efb..97c63604717d8cda7e22f659a3991fb00a68a3b3 100644
--- a/telemetry/telemetry/testing/fakes/__init__.py
+++ b/telemetry/telemetry/testing/fakes/__init__.py
@@ -56,13 +56,13 @@ class FakePlatform(object):
return False
def GetDeviceTypeName(self):
- raise NotImplementedError
+ return 'FakeDevice'
def GetArchName(self):
raise NotImplementedError
def GetOSName(self):
- raise NotImplementedError
+ return 'FakeOS'
def GetOSVersionName(self):
raise NotImplementedError
@@ -302,6 +302,9 @@ class _FakeTracingController(object):
def ClearStateIfNeeded(self):
pass
+ def IsChromeTracingSupported(self):
+ return True
+
class _FakeNetworkController(object):
def __init__(self):

Powered by Google App Engine
This is Rietveld 408576698