Track telemetry benchmark cycle time

telemetry/telemetry/internal/story_runner_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import math
 import os
 import StringIO
 import sys
 import unittest
 
@@ skipping 1018 matching lines @@
       mock.call.test.WillRunStory(root_mock.state.platform),
       mock.call.state.WillRunStory(root_mock.story),
       mock.call.state.CanRunStory(root_mock.story),
       mock.call.state.RunStory(root_mock.results),
       mock.call.test.Measure(root_mock.state.platform, root_mock.results),
       mock.call.state.DumpStateUponFailure(root_mock.story, root_mock.results),
       mock.call.results.AddValue(FailureValueMatcher('foo')),
       mock.call.state.DidRunStory(root_mock.results),
       mock.call.test.DidRunStory(root_mock.state.platform)
     ])
+
+  def testRunBenchmarkTimeDuration(self):

[nednguyen, 2017/03/17 20:49:32]

Can you only mock time and not other story_runner.Run? See test in
testPagesetRepeat.

This test seems mostly test certain methods be called with some expected
arguments. I generally prefer test that treat the state as blackbox & only
asserting the outcome.

[nednguyen, 2017/03/23 21:29:20]

Ping

[martiniss, 2017/03/23 23:22:21]

Done.

+    benchmark_mock = mock.Mock()
+    opts = mock.MagicMock()
+    opts.__class__.__name__ = '_FakeBrowserFinderOptions'
+    opts.upload_results = False
+
+    with mock.patch('telemetry.internal.story_runner.Run'):
+      create_mock = mock.Mock()
+      create_mock.failures = []
+      create_mock.AddSummaryValue = add_value = mock.Mock()
+
+      c_mock = mock.MagicMock()
+      c_mock.__enter__ = mock.Mock(return_value=create_mock)
+      wrapper = mock.MagicMock(return_value=c_mock)
+      with mock.patch(
+          'telemetry.internal.story_runner.results_options.CreateResults',
+          new=wrapper):
+
+        res = story_runner.RunBenchmark(benchmark_mock, opts)
+        self.assertEqual(res, 0)
+
+        self.assertEquals(len(add_value.call_args_list), 1)
+        self.assertEquals(len(add_value.call_args_list[0][0]), 1)
+        # First call -> index into the call object -> first item in call tuple
+        arg = add_value.call_args_list[0][0][0]
+        self.assertTrue(isinstance(arg, scalar.ScalarValue))
+        self.assertEqual(arg.name, 'BenchmarkDuration')
+