Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.h

Issue 2749593002: Remove argument to LayoutSVGResourceGradient::collectGradientAttributes (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2006 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 3 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
4 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
11 * This library is distributed in the hope that it will be useful, 11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details. 14 * Library General Public License for more details.
15 * 15 *
16 * You should have received a copy of the GNU Library General Public License 16 * You should have received a copy of the GNU Library General Public License
17 * along with this library; see the file COPYING.LIB. If not, write to 17 * along with this library; see the file COPYING.LIB. If not, write to
18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 * Boston, MA 02110-1301, USA. 19 * Boston, MA 02110-1301, USA.
20 */ 20 */
21 21
22 #ifndef LayoutSVGResourceGradient_h 22 #ifndef LayoutSVGResourceGradient_h
23 #define LayoutSVGResourceGradient_h 23 #define LayoutSVGResourceGradient_h
24 24
25 #include "core/layout/svg/LayoutSVGResourcePaintServer.h" 25 #include "core/layout/svg/LayoutSVGResourcePaintServer.h"
26 #include "core/svg/SVGGradientElement.h" 26 #include "core/svg/SVGGradientElement.h"
27 #include "platform/geometry/FloatRect.h"
28 #include "platform/graphics/Gradient.h" 27 #include "platform/graphics/Gradient.h"
29 #include "platform/transforms/AffineTransform.h" 28 #include "platform/transforms/AffineTransform.h"
30 #include "wtf/HashMap.h" 29 #include "wtf/HashMap.h"
31 #include <memory> 30 #include <memory>
32 31
33 namespace blink { 32 namespace blink {
34 33
35 struct GradientData { 34 struct GradientData {
36 USING_FAST_MALLOC(GradientData); 35 USING_FAST_MALLOC(GradientData);
37 36
(...skipping 12 matching lines...) Expand all
50 49
51 SVGPaintServer preparePaintServer(const LayoutObject&) final; 50 SVGPaintServer preparePaintServer(const LayoutObject&) final;
52 51
53 bool isChildAllowed(LayoutObject* child, const ComputedStyle&) const final; 52 bool isChildAllowed(LayoutObject* child, const ComputedStyle&) const final;
54 53
55 protected: 54 protected:
56 void addStops(Gradient&, const Vector<Gradient::ColorStop>&) const; 55 void addStops(Gradient&, const Vector<Gradient::ColorStop>&) const;
57 56
58 virtual SVGUnitTypes::SVGUnitType gradientUnits() const = 0; 57 virtual SVGUnitTypes::SVGUnitType gradientUnits() const = 0;
59 virtual AffineTransform calculateGradientTransform() const = 0; 58 virtual AffineTransform calculateGradientTransform() const = 0;
60 virtual bool collectGradientAttributes(SVGGradientElement*) = 0; 59 virtual bool collectGradientAttributes() = 0;
61 virtual PassRefPtr<Gradient> buildGradient() const = 0; 60 virtual PassRefPtr<Gradient> buildGradient() const = 0;
62 61
63 static GradientSpreadMethod platformSpreadMethodFromSVGType( 62 static GradientSpreadMethod platformSpreadMethodFromSVGType(
64 SVGSpreadMethodType); 63 SVGSpreadMethodType);
65 64
66 private: 65 private:
67 bool m_shouldCollectGradientAttributes : 1; 66 bool m_shouldCollectGradientAttributes : 1;
68 HashMap<const LayoutObject*, std::unique_ptr<GradientData>> m_gradientMap; 67 HashMap<const LayoutObject*, std::unique_ptr<GradientData>> m_gradientMap;
69 }; 68 };
70 69
71 } // namespace blink 70 } // namespace blink
72 71
73 #endif 72 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698