Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2749543003: Reset TaskScheduler during PepperToVideoTrackAdapterTest tear down. (Closed)

Created:
3 years, 9 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset TaskScheduler during PepperToVideoTrackAdapterTest tear down. PepperToVideoTrackAdapterTest instantiates a ChildProcess which registers a global TaskScheduler. To allow CONTINUE_ON_SHUTDOWN tasks to continue running, ~ChildProcess does not clear that global TaskScheduler. This is problematic when another test tries to register TaskScheduler in the same process later on. With this CL, PepperToVideoTrackAdapterTest::TearDown clears the global TaskScheduler registered by ChildProcess. BUG=682370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M content/renderer/media/pepper_to_video_track_adapter_unittest.cc View 3 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
fdoray
PTAL
3 years, 9 months ago (2017-03-14 13:16:22 UTC) #3
chfremer
3 years, 9 months ago (2017-03-14 16:18:15 UTC) #4
On 2017/03/14 13:16:22, fdoray wrote:
> PTAL

See comment #6 in
https://bugs.chromium.org/p/chromium/issues/detail?id=682370#c6.
I don't think we should require every test that uses ChildProcess to manually
(and unobviously) have clean up like this.

Powered by Google App Engine
This is Rietveld 408576698