MD Settings: adjust iron-list focus row behaviors.

chrome/test/data/webui/settings/focusable_iron_list_item_behavior_test.js

Index: chrome/test/data/webui/settings/focusable_iron_list_item_behavior_test.js
diff --git a/chrome/test/data/webui/settings/focusable_iron_list_item_behavior_test.js b/chrome/test/data/webui/settings/focusable_iron_list_item_behavior_test.js
deleted file mode 100644
index 3decda4e417e9f697c75396851f404db52e19021..0000000000000000000000000000000000000000
--- a/chrome/test/data/webui/settings/focusable_iron_list_item_behavior_test.js
+++ /dev/null
@@ -1,62 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-suite('focusable-iron-list-item-behavior', function() {

[hcarmona, 2017/03/16 21:31:54]

Do we need to port over some of these tests?

click vs keyboard seems important

[scottchen, 2017/03/17 21:26:58]

I have a new mouseFocused flag which makes sure mouse clicks doesn't focus the
row or the icon.
The rest of the tests regarding keyboard interaction is now relying on iron-list
to do the right thing, so I didn't port them over (and assumes that iron-list
has proper unit-testing).

[hcarmona, 2017/03/17 23:55:50]

Acknowledged.

-  /** @type {FocusableIronListItemElement} */ var testElement;
-
-  suiteSetup(function() {
-    Polymer({
-      is: 'focusable-item',
-      behaviors: [FocusableIronListItemBehavior],
-    });
-  });
-
-  setup(function() {
-    PolymerTest.clearBody();
-
-    testElement = document.createElement('focusable-item');
-    document.body.appendChild(testElement);
-  });
-
-  test('clicking applies .no-outline', function() {
-    assertFalse(testElement.classList.contains('no-outline'));
-    MockInteractions.tap(testElement);
-    assertTrue(testElement.classList.contains('no-outline'));
-  });
-
-  test('clicking doesn\'t apply .no-outline to key-focused item', function() {
-    assertFalse(testElement.classList.contains('no-outline'));
-    MockInteractions.keyUpOn(testElement);
-    MockInteractions.tap(testElement);
-    assertFalse(testElement.classList.contains('no-outline'));
-  });
-
-  test('clicking applies .no-outline to key-blurred item', function() {
-    assertFalse(testElement.classList.contains('no-outline'));
-    MockInteractions.keyUpOn(testElement);
-    MockInteractions.tap(testElement);
-    assertFalse(testElement.classList.contains('no-outline'));
-    MockInteractions.keyDownOn(testElement);
-    MockInteractions.tap(testElement);
-    assertTrue(testElement.classList.contains('no-outline'));
-  });
-
-  test('"enter" key event should not propagate out of element', function() {
-    var container = document.createElement('div');
-    container.appendChild(testElement);
-    document.body.appendChild(container);
-
-    var reached = false;
-    container.addEventListener('keydown', function() {
-      reached = true;
-    });
-
-    MockInteractions.keyEventOn(testElement, 'keydown', 13, undefined, 'Enter');
-    assertFalse(reached);
-
-    // Test other keys still work.
-    MockInteractions.keyEventOn(testElement, 'keydown', 9, undefined, 'Tab');
-    assertTrue(reached);
-  });
-});