Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2963)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html

Issue 2749513004: MD Settings: adjust iron-list focus row behaviors. (Closed)
Patch Set: fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
index 033e9fae423433a6c74974e1f74cd03418d6458d..6bbaad1fb4f5a69af6f63358ff3c9340f99a91e6 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
+++ b/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
@@ -4,7 +4,7 @@
<link rel="import" href="chrome://resources/html/icon.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="../controls/extension_controlled_indicator.html">
-<link rel="import" href="../focusable_iron_list_item_behavior.html">
+<link rel="import" href="../focus_row_behavior.html">
<link rel="import" href="search_engine_dialog.html">
<link rel="import" href="search_engine_entry_css.html">
<link rel="import" href="search_engines_browser_proxy.html">
@@ -50,7 +50,7 @@
<settings-search-engine-dialog model="[[engine]]">
</settings-search-engine-dialog>
</template>
- <div class="list-item">
+ <div class="list-item" focus-row-container>
<div id="name-column">
<div class="favicon-image"
style="background-image: [[getIconSet_(engine.iconURL)]]"></div>
@@ -58,8 +58,9 @@
</div>
<div id="keyword-column">[[engine.keyword]]</div>
<div id="url-column" class="text-elide">[[engine.url]]</div>
- <paper-icon-button icon="cr:more-vert" tabindex$="[[tabindex]]"
- on-tap="onDotsTap_" title="$i18n{moreActions}">
+ <paper-icon-button icon="cr:more-vert" on-tap="onDotsTap_"
+ title="$i18n{moreActions}" focus-row-control
+ focus-type='cr-menu-button'>
</paper-icon-button>
<dialog is="cr-action-menu">
<button class="dropdown-item" role="option" on-tap="onMakeDefaultTap_"

Powered by Google App Engine
This is Rietveld 408576698