Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> | 1 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> |
| 2 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html"> | 2 <link rel="import" href="chrome://resources/cr_elements/cr_lazy_render/cr_lazy_r ender.html"> |
| 3 <link rel="import" href="chrome://resources/cr_elements/icons.html"> | 3 <link rel="import" href="chrome://resources/cr_elements/icons.html"> |
| 4 <link rel="import" href="chrome://resources/html/polymer.html"> | 4 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 5 <link rel="import" href="chrome://resources/html/icon.html"> | 5 <link rel="import" href="chrome://resources/html/icon.html"> |
| 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> | 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> |
| 7 <link rel="import" href="startup_urls_page_browser_proxy.html"> | 7 <link rel="import" href="startup_urls_page_browser_proxy.html"> |
| 8 <link rel="import" href="../focus_row_behavior.html"> | |
| 8 <link rel="import" href="../settings_shared_css.html"> | 9 <link rel="import" href="../settings_shared_css.html"> |
| 9 | 10 |
| 10 <dom-module id="settings-startup-url-entry"> | 11 <dom-module id="settings-startup-url-entry"> |
| 11 <template> | 12 <template> |
| 12 <style include="settings-shared"> | 13 <style include="settings-shared"> |
| 13 .hide-overflow { | 14 .hide-overflow { |
| 14 overflow: hidden; | 15 overflow: hidden; |
| 15 } | 16 } |
| 16 </style> | 17 </style> |
| 17 <div class="list-item"> | 18 <div class="list-item" focus-row-container> |
| 18 <div class="favicon-image" | 19 <div class="favicon-image" |
| 19 style="background-image: [[getIconSet_(model.url)]]"> | 20 style="background-image: [[getIconSet_(model.url)]]"> |
| 20 </div> | 21 </div> |
| 21 <div class="middle hide-overflow"> | 22 <div class="middle hide-overflow"> |
| 22 <div class="text-elide">[[model.title]]</div> | 23 <div class="text-elide">[[model.title]]</div> |
| 23 <div class="text-elide secondary">[[model.url]]</div> | 24 <div class="text-elide secondary">[[model.url]]</div> |
| 24 </div> | 25 </div> |
| 25 <template is="dom-if" if="[[editable]]"> | 26 <template is="dom-if" if="[[editable]]"> |
|
hcarmona
2017/03/16 21:31:54
What happens if nothing is actionable? Where does
scottchen
2017/03/17 21:26:58
Discussed offline and found no case of a row that
| |
| 26 <paper-icon-button id="dots" icon="cr:more-vert" | 27 <paper-icon-button id="dots" icon="cr:more-vert" on-tap="onDotsTap_" |
| 27 tabindex$="[[tabindex]]" on-tap="onDotsTap_" | 28 title="$i18n{moreActions}" focus-row-control type="menu"> |
| 28 title="$i18n{moreActions}"> | |
| 29 </paper-icon-button> | 29 </paper-icon-button> |
| 30 <template is="cr-lazy-render" id="menu"> | 30 <template is="cr-lazy-render" id="menu"> |
| 31 <dialog is="cr-action-menu"> | 31 <dialog is="cr-action-menu"> |
| 32 <button class="dropdown-item" role="option" on-tap="onEditTap_"> | 32 <button class="dropdown-item" role="option" on-tap="onEditTap_"> |
| 33 $i18n{edit} | 33 $i18n{edit} |
| 34 </button> | 34 </button> |
| 35 <button class="dropdown-item" role="option" id="remove" | 35 <button class="dropdown-item" role="option" id="remove" |
| 36 on-tap="onRemoveTap_"> | 36 on-tap="onRemoveTap_"> |
| 37 $i18n{onStartupRemove} | 37 $i18n{onStartupRemove} |
| 38 </button> | 38 </button> |
| 39 </dialog> | 39 </dialog> |
| 40 </template> | 40 </template> |
| 41 </template> | 41 </template> |
| 42 </div> | 42 </div> |
| 43 </template> | 43 </template> |
| 44 <script src="startup_url_entry.js"></script> | 44 <script src="startup_url_entry.js"></script> |
| 45 </dom-module> | 45 </dom-module> |
| OLD | NEW |