Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/wasm/wasm_indexeddb_test.js

Issue 2749503002: [wasm] enable wasm structured cloning in specific cases (Closed)
Patch Set: async Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/wasm/wasm_indexeddb_test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/wasm/wasm_indexeddb_test.js b/third_party/WebKit/LayoutTests/http/tests/wasm/wasm_indexeddb_test.js
index 4b7cafe45ba38b5e3ee95bc5bb4fb6a20096819b..f8b83b596b8df192f60463c4b8dc1f030c5b99fe 100644
--- a/third_party/WebKit/LayoutTests/http/tests/wasm/wasm_indexeddb_test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/wasm/wasm_indexeddb_test.js
@@ -7,9 +7,9 @@ var obj_store = 'store';
var module_key = 'my_module';
function createAndSaveToIndexedDB() {
- return new Promise( (resolve, reject) => {
+ return new Promise((resolve, reject) => {
createWasmModule()
- .then (mod => {
+ .then(mod => {
var delete_request = indexedDB.deleteDatabase(db_name);
delete_request.onsuccess = function() {
var open_request = indexedDB.open(db_name);
@@ -25,6 +25,9 @@ function createAndSaveToIndexedDB() {
tx.oncomplete = function() {
resolve();
};
+ tx.onabort = function() {
+ reject(transaction.error);
+ };
};
};
})
@@ -32,8 +35,10 @@ function createAndSaveToIndexedDB() {
});
}
+var kErrorMsg = "failed to retrieve object";
+
function loadFromIndexedDB(prev) {
- return new Promise(resolve => {
+ return new Promise((resolve, reject) => {
prev.then(() => {
var open_request = indexedDB.open(db_name);
open_request.onsuccess = function() {
@@ -43,16 +48,32 @@ function loadFromIndexedDB(prev) {
var get_request = store.get(module_key);
get_request.onsuccess = function() {
var mod = get_request.result;
- var instance = new WebAssembly.Instance(get_request.result);
- resolve(instance.exports.increment(1));
+ if (mod instanceof WebAssembly.Module) {
+ try {
+ var instance = new WebAssembly.Instance(mod);
+ } catch(e) {
+ reject(e);
+ return;
+ }
+ resolve(instance.exports.increment(1));
+ } else {
+ assert_equals(mod, null);
+ reject(new Error(kErrorMsg));
+ }
};
};
});
});
}
-function TestIndexedDBLoadStore() {
+function TestIndexedDBLoadStoreSecure() {
+ return loadFromIndexedDB(createAndSaveToIndexedDB())
+ .then(res => assert_equals(res, 2),
+ error => assert_unreached(error));
+}
+
+function TestIndexedDBLoadStoreInsecure() {
return loadFromIndexedDB(createAndSaveToIndexedDB())
- .then((res) => assert_equals(res, 2))
- .catch(error => assert_unreached(error));
+ .then(assert_unreached,
+ error => assert_equals(error.message, kErrorMsg));
}

Powered by Google App Engine
This is Rietveld 408576698