[wasm] enable wasm structured cloning in specific cases

third_party/WebKit/LayoutTests/http/tests/wasm/wasm_indexeddb_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var db_name = 'db';
 var obj_store = 'store';
 var module_key = 'my_module';
 
 function createAndSaveToIndexedDB() {
   return new Promise( (resolve, reject) => {

[jsbell, 2017/03/22 17:41:07]

nit: remove space between ( (

(not new in this CL)

[Mircea Trofin, 2017/03/22 23:31:15]

Done.

     createWasmModule()
       .then (mod => {

[jsbell, 2017/03/22 17:41:07]

nit: remove space between then (

(not new in this CL)

[Mircea Trofin, 2017/03/22 23:31:15]

Done.

         var delete_request = indexedDB.deleteDatabase(db_name);
         delete_request.onsuccess = function() {
           var open_request = indexedDB.open(db_name);
           open_request.onupgradeneeded = function() {
             var db = open_request.result;
             db.createObjectStore(obj_store);
           };
           open_request.onsuccess = function() {
             var db = open_request.result;
             var tx = db.transaction(obj_store, 'readwrite');
             var store = tx.objectStore(obj_store);
             store.put(mod, module_key);

[jsbell, 2017/03/22 17:41:06]

Hrm... I would have expected this to throw DataCloneError in the insecure case
rather than silently failing to serialize the data.

[Mircea Trofin, 2017/03/22 23:31:15]

Acknowledged. Will update once we get clarity over the desired behavior, if
that's OK.

             tx.oncomplete = function() {

[jsbell, 2017/03/22 17:41:07]

not new in this CL, but maybe add: 

tx.onabort = function() { reject(transaction.error); };

[Mircea Trofin, 2017/03/22 23:31:15]

Done.

               resolve();
             };
           };
         };
       })
       .catch(error => reject(error));
   });
 }
 
+var kErrorMsg = "failed to retrieve object";
+
 function loadFromIndexedDB(prev) {
-  return new Promise(resolve => {
+  return new Promise((resolve, reject) => {
     prev.then(() => {
       var open_request = indexedDB.open(db_name);
       open_request.onsuccess = function() {
         var db = open_request.result;
         var tx = db.transaction(obj_store);
         var store = tx.objectStore(obj_store);
         var get_request = store.get(module_key);
         get_request.onsuccess = function() {
           var mod = get_request.result;
-          var instance = new WebAssembly.Instance(get_request.result);
-          resolve(instance.exports.increment(1));
+          if (mod instanceof WebAssembly.Module) {
+            var instance = new WebAssembly.Instance(mod);

[jsbell, 2017/03/22 17:41:06]

Since the constructor may throw, maybe wrap in a try/catch block where catch
calls reject() ?

(Not critical - it's just a difference between the test timing out or getting a
useful message. It'll fail either way.)

[Mircea Trofin, 2017/03/22 23:31:15]

Done.

+            resolve(instance.exports.increment(1));
+          } else {
+            reject(new Error(kErrorMsg));

[jsbell, 2017/03/22 17:41:07]

We should be asserting something about what `mod` is in this case, at the very
least.

[Mircea Trofin, 2017/03/22 23:31:15]

Done.

+          }
         };
       };
     });
   });
 }
 
-function TestIndexedDBLoadStore() {
-  return loadFromIndexedDB(createAndSaveToIndexedDB())
-    .then((res) => assert_equals(res, 2))
-    .catch(error => assert_unreached(error));
+function TestIndexedDBLoadStoreSecure() {
+  if (window.location.origin != get_host_info().AUTHENTICATED_ORIGIN) {
+    window.location = get_host_info().AUTHENTICATED_ORIGIN + window.location.pathname;
+  } else {
+    return loadFromIndexedDB(createAndSaveToIndexedDB())
+      .then((res) => assert_equals(res, 2))

[jsbell, 2017/03/22 17:41:07]

I don't think you want to use .then().catch() here because if the callback for
.then() throws it will propagate to the .catch().

You probably want the two-argument form of then(), i.e.

.then(
  result => assert_equals(result, 2),
  error => assert_unreached(error)
);

[Mircea Trofin, 2017/03/22 23:31:15]

Done.

+      .catch(error => assert_unreached(error));
+  }
 }
+
+function TestIndexedDBLoadStoreInsecure() {
+  if (window.location.origin != get_host_info().UNAUTHENTICATED_ORIGIN) {
+    window.location = get_host_info().UNAUTHENTICATED_ORIGIN + window.location.pathname;
+  } else {
+    return loadFromIndexedDB(createAndSaveToIndexedDB())
+      .then(assert_unreached)

[jsbell, 2017/03/22 17:41:07]

same as above re: two argument form of then()

[Mircea Trofin, 2017/03/22 23:31:15]

Done.

+      .catch(error => assert_equals(error.message, kErrorMsg));
+  }
+}